Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed pinning of scipy and pandas #131

Closed
wants to merge 2 commits into from

Conversation

cchwala
Copy link
Contributor

@cchwala cchwala commented Oct 5, 2023

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (700c768) 73.25% compared to head (02f582c) 73.25%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   73.25%   73.25%           
=======================================
  Files          29       29           
  Lines        1077     1077           
=======================================
  Hits          789      789           
  Misses        288      288           
Flag Coverage Δ
unittests 73.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
setup.py 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cchwala
Copy link
Contributor Author

cchwala commented Oct 5, 2023

unfortunately the usage of pykrige, which was the reason why scipy was pinned to v1.9 quite some time ago, is not tested. Hence from CI it is not clear if the unpinning has an effect on pykrige usage...

@cchwala
Copy link
Contributor Author

cchwala commented Oct 5, 2023

🤔 ... there seems to be a test for it here, but according to codecov the kriging functions are not covered...

@cchwala
Copy link
Contributor Author

cchwala commented Oct 5, 2023

update: somebody mixed up the usage of IdwKdtreeInterpolator and OrdinaryKrigingInterpolator in TestOrdiniaryKrigingInterpolator.

@cchwala
Copy link
Contributor Author

cchwala commented Oct 5, 2023

Closing, because the two commits here have been in included in #132

@cchwala cchwala closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python 3.11 incompatible with pycomlink 0.3.8
2 participants