Remove ODES solver

[kratman]

Description

Since the ODES solver was causing issues for upgrading to python 3.12 and might not offer anything outside of our other solvers, it might be able to be removed.

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all (or $ nox -s tests)
• The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[kratman]

I created this PR very early since I want to test on CI. This is in no way ready for review

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (a3db966) to head (ba3d9b5).
Report is 1 commits behind head on develop.

❗ Current head ba3d9b5 differs from pull request most recent head 34d4b84. Consider uploading reports for the commit 34d4b84 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3932      +/-   ##
===========================================
- Coverage    99.60%   99.58%   -0.03%     
===========================================
  Files          259      257       -2     
  Lines        21347    21190     -157     
===========================================
- Hits         21263    21102     -161     
- Misses          84       88       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[valentinsulzer]

🎵 Should Old Acquaintance be forgot... 🎵

[agriyakhetarpal]

For the macOS failures, removing some of the recent pybamm-requires caches should work (this comes from time to time whenever CMake puts out a new release, and I always forget about fixing it)

[kratman]

Since tests seem to be passing, I am going to open this up for review

Extra things for reviewers to check:

• Updated documentation
• Make sure there are no tests/scripts outside of CI that I missed
• If there are use-cases for ODEs that I missed, please mention them
• Do any of our linux/mac dependencies in the instructions/docker get used for only ODES? (Agriya: verified, no extra dependencies)

[Saransh-cpp]

Thanks, @kratman! This looks good!

Dockerfile should also be updated to remove the extra odes dependency. Additionally, the CHANGELOG note should ideally be placed under the "Breaking changes" section and should specify why the solver was removed.

[kratman]

Thanks, @kratman! This looks good!

Dockerfile should also be updated to remove the extra odes dependency. Additionally, the CHANGELOG note should ideally be placed under the "Breaking changes" section and should specify why the solver was removed.

Yeah I was making the changelog now. Good catch on the dockerfile

[kratman]

@pybamm-team/maintainers If you have checked any of the things in my checklist, please check them off

[agriyakhetarpal]

I cannot find any more references besides these, thanks! Also, could you exclude the IDAKLUJax notebook from running in nox -s examples for Python <3.9 because JAX is unavailable? It has been failing our scheduled tests on 3.8 recently

[agriyakhetarpal]

Oops, it looks like @Saransh-cpp reviewed at the same time as I did, lol

Do any of our linux/mac dependencies in the instructions/docker get used for only ODES?

I checked the Dockerfile and it has just SUNDIALS_INST as an unneeded environment variable, all of the system-level dependencies in it (and the docs) are required

[agriyakhetarpal]

So long, old friend

[agriyakhetarpal]

On another note, we shouldn't need to install two of the macOS system dependencies now with this, just graphviz and libomp should be required. We are fine with using Accelerate as a BLAS vendor and we needed gcc to get gfortran earlier for compiling scikits.odes (it wasn't being used for compiling IDAKLU anyway, we used the system Clang for that). I guess these changes would probably be better in a separate PR.

[kratman]

On another note, we shouldn't need to install two of the macOS system dependencies now with this, just graphviz and libomp should be required. We are fine with using Accelerate as a BLAS vendor and we needed gcc to get gfortran earlier for compiling scikits.odes (it wasn't being used for compiling IDAKLU anyway, we used the system Clang for that). I guess these changes would probably be better in a separate PR.

Can you add this to #3941 and I will look at it there

Changes were address. Additional improvements will be done in a follow task

[kratman]

Coverage will be fixed in #3942