Partitioning the individual tags page #5902

gautamig54 · 2019-06-14T04:25:56Z

Fixes #5890 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

CleverFool77 · 2019-06-14T09:19:46Z

Hi @gautamig54 Should I start the work on nav tabs to dropdown ? Coz I don't think that it's associated with other parts.

gautamig54 · 2019-06-14T09:33:59Z

Sure @CleverFool77. You can start creating that. We can position it once this PR gets merged. I have also started with the main tag card.

gautamig54 · 2019-06-14T09:34:28Z

@jywarren This PR is ready for merge.

gautamig54 · 2019-06-14T09:40:44Z

@CleverFool77 I would suggest that you start with the image first.It will be better if do things in order. What do you say?
After you resize and position the image, I can position the tags card as well.
What do you say?

CleverFool77 · 2019-06-14T10:01:06Z

I'm not yet clear regarding the image.
So regarding the image, Should I remove all the data above nav tabs leaving only image and people following section ?
Ca you send me an example link for tag where there is a image.

gautamig54 · 2019-06-14T10:06:47Z

The data above the nav tabs will be divided into other segments like, related tags will go to the sidebar, the wiki info and the other options will go to the tag card.
I think you need to resize the image. Also, as discussed by @jywarren, the tags with no image, will display a light grey background in place of the image.
Sounds fine?

CleverFool77 · 2019-06-14T10:07:59Z

The data above the nav tabs will be divided into other segments like, related tags will go to the sidebar, the wiki info and the other options will go to the tag card.
I think you need to resize the image. Also, as discussed by @jywarren, the tags with no image, will display a light grey background in place of the image.
Sounds fine?

Exactly. So for now, Should I remove them, later we will add them in sidebar or wherever they are needed.

gautamig54 · 2019-06-14T10:09:33Z

Since it is not a shadow page, therefore I don't think removing them is a good idea. We can just change their location as we proceed to the tasks.

CleverFool77 · 2019-06-14T10:12:06Z

Since it is not a shadow page, therefore I don't think removing them is a good idea. We can just change their location as we proceed to the tasks.

Ohkk. I'll just let it remain like usual at it's position then. And for now I'll work on tag's wiki image adjustment to take full span and those with no wiki to have grey image. And over it to have people following data in right-bottom corner. Cool.

gautamig54 · 2019-06-14T10:12:55Z

That sounds great !

jywarren · 2019-06-18T21:44:40Z

Ah but if we're not on a shadow page, should we be merging this with the Lorem Ipsum text on the side? Maybe best come up with a short term fix for that, or hold this and open PRs against it so we can merge to master only once it's ready for people to see? Thank you!

gautamig54 · 2019-06-19T05:53:40Z

@jywarren Can we add the related tags section on the right side, removing the Lorem Ipsum text. It will good to go as for now, until we add the map.
What do you think @CleverFool77 ?

CleverFool77 · 2019-06-19T06:51:16Z

Hi @gautamig54 Does UI as per new style guide have related tags section in second column ? If yes, then we can add it. Or else lorem ipsum text for now would be good. or how about combining two parts of the issue here and adding map here only ? So we won't have empty space ?
Thanks !!!

CleverFool77 · 2019-06-19T06:53:30Z

Hi @gautamig54 Juts added your PR to project in-progress card.
Thanks !!

gautamig54 · 2019-06-19T07:11:30Z

There is no section for related tags in the new style guide. I thought it will be good to place them in the side section. This can be a temporary solution.
I also like your idea of adding a map in this PR itself. Let do that only. What do you say?

CleverFool77 · 2019-06-19T07:43:05Z

There is no section for related tags in the new style guide. I thought it will be good to place them in the side section. This can be a temporary solution.
I also like your idea of adding a map in this PR itself. Let do that only. What do you say?

great. 🎉

jywarren · 2019-06-19T14:35:03Z

Yes, the related tags or map would both work. I actually updated the style guide with a small section below the main example showing how related tags could work, after you suggested it! It looks good!

…

On Wed, Jun 19, 2019 at 2:54 AM Lekhika Dugtal ***@***.***> wrote: Hi @gautamig54 <https://github.com/gautamig54> Juts added your PR to project in-progress card. Thanks !! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5902?email_source=notifications&email_token=AAAF6J2INLCUVPXVLGH2ORTP3HJWVA5CNFSM4HYEG7JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYA4GOA#issuecomment-503431992>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6JYPCKU7RJ5TU7IGX3LP3HJWVANCNFSM4HYEG7JA> .

gautamig54 · 2019-06-20T14:29:38Z

@jywarren I have placed the related tags on the sidebar. This PR is ready for merge.

jywarren · 2019-06-20T16:22:33Z

Nice! We have some issue where the parallel tests are now overwriting each others comments so the screenshots are harder to find but you can get them in the "revisions" of the Dangerbot comment. Here's what yours looks like!

jywarren · 2019-06-20T16:22:54Z

It looks great. Any idea why tests aren't passing? Thanks!

gautamig54 · 2019-06-21T19:23:46Z

I removed the conflicts and rebased the code, I am not able to understand why the tests aren't passing.

asquare14 · 2019-06-22T02:58:53Z

I saw that the tests are failing because the tests are not able to get the expected components. I think you will have tp rewrite the tests too. Additionally, please restart your Travis once to see which ones were flaky.

gautamig54 · 2019-06-28T08:07:18Z

@jywarren This issue is pending to be merged. Kindly look into this. Thanks!

jywarren · 2019-06-28T19:42:34Z

Hmm. I've seen this before: https://travis-ci.org/publiclab/plots2/jobs/548813611#L4029

 FAIL["test_graph", #<Minitest::Reporters::Suite:0x0000559a12381380 @name="TagSelectionTest">, 0.3034094249999839]
 test_graph#TagSelectionTest (0.30s)
        Expected: 16
          Actual: 20
        test/unit/tag_selection_test.rb:12:in `block in <class:TagSelectionTest>'

I think it's unrelated. I'll restart this but we can also rebase if it fails again.

jywarren · 2019-06-28T19:43:35Z

Here, on the other hand, i haven't seen this. But we aren't changing controllers, are we?

https://travis-ci.org/publiclab/plots2/jobs/548813612#L4029-L4077


 FAIL["test_should_have_a_active_asked_and_an_inactive_answered_tab_for_question", #<Minitest::Reporters::Suite:0x00005582b7d9e740 @name="TagControllerTest">, 51.05422450999998]
 test_should_have_a_active_asked_and_an_inactive_answered_tab_for_question#TagControllerTest (51.05s)
        Expected: 2
          Actual: 1
        test/functional/tag_controller_test.rb:577:in `block in <class:TagControllerTest>'
 FAIL["test_should_have_active_Research_tab_for_notes", #<Minitest::Reporters::Suite:0x00005582b7a5c140 @name="TagControllerTest">, 51.17118526999997]
 test_should_have_active_Research_tab_for_notes#TagControllerTest (51.17s)
        Expected: 2
          Actual: 1
        test/functional/tag_controller_test.rb:440:in `block in <class:TagControllerTest>'
 FAIL["test_should_have_active_question_tab_for_question", #<Minitest::Reporters::Suite:0x00005582b743b9f0 @name="TagControllerTest">, 51.31611122600003]
 test_should_have_active_question_tab_for_question#TagControllerTest (51.32s)
        Expected: 2
          Actual: 1
        test/functional/tag_controller_test.rb:450:in `block in <class:TagControllerTest>'
 FAIL["test_should_have_active_question_tab_for_question_for_show_for_author", #<Minitest::Reporters::Suite:0x00005582b704bf20 @name="TagControllerTest">, 51.426479293]
 test_should_have_active_question_tab_for_question_for_show_for_author#TagControllerTest (51.43s)
        Expected: 2
          Actual: 1
        test/functional/tag_controller_test.rb:566:in `block in <class:TagControllerTest>'
 FAIL["test_should_show_a_featured_wiki_page_at_top,_if_it_exists", #<Minitest::Reporters::Suite:0x00005582b5744c98 @name="TagControllerTest">, 51.897871684999984]
 test_should_show_a_featured_wiki_page_at_top,_if_it_exists#TagControllerTest (51.90s)
        Expected exactly 1 element matching "#wiki-content", found 2..
        Expected: 1
          Actual: 2
        test/functional/tag_controller_test.rb:289:in `block in <class:TagControllerTest>'
 FAIL["test_tag_contributors", #<Minitest::Reporters::Suite:0x00005582b8377590 @name="TagControllerTest">, 53.44871669599996]
 test_tag_contributors#TagControllerTest (53.45s)
        Expected: 2
          Actual: 1
        test/functional/tag_controller_test.rb:361:in `block in <class:TagControllerTest>'
 FAIL["test_tag_show", #<Minitest::Reporters::Suite:0x00005582b6d89210 @name="TagControllerTest">, 53.86620479599998]
 test_tag_show#TagControllerTest (53.87s)
        Expected exactly 1 element matching "#wiki-content", found 2..
        Expected: 1
          Actual: 2
        test/functional/tag_controller_test.rb:171:in `block in <class:TagControllerTest>'
 FAIL["test_wildcard_tag_should_have_a_active_asked_and_an_inactive_answered_tab_for_question", #<Minitest::Reporters::Suite:0x00005582b757ec18 @name="TagControllerTest">, 54.965742990000024]
 test_wildcard_tag_should_have_a_active_asked_and_an_inactive_answered_tab_for_question#TagControllerTest (54.97s)
        Expected: 2
          Actual: 1
        test/functional/tag_controller_test.rb:246:in `block in <class:TagControllerTest>'

jywarren · 2019-06-28T20:29:37Z

OK - indeed, these functional tests are testing for things on the page:

plots2/test/functional/tag_controller_test.rb

Lines 571 to 579 in 78fffff

    
           test 'should have a active asked and an inactive answered tab for question' do 
        
             tag = tags(:question) 
        
             get :show_for_author, params: { id: tag.name, author: 'jeff' } 
        
             selector = css_select '#asked-tab.active' 
        
             assert_equal selector.size, 1 
        
             assert_select '#answered-tab', 1 
        
           end

So, here, some tabs, items have been removed, and we should go through them one by one by the line numbers of the failing tests, and update them to match the new design. Does that make sense?

Then we should be good to go!

gautamig54 · 2019-06-29T08:10:43Z

We are not making any changes in the controllers. Its just the view files.

asquare14 · 2019-06-29T09:26:17Z

Yes, but the controller expects certain UI components for which it is testing.
Since the UI is changing, tests are failing. You'll need to update the tests. Feel free to ask for help, I have some experience with testing. Hope this makes sense :D

gautamig54 · 2019-07-01T15:01:03Z

I guess the issue is with the active tabs. That's where the cases are failing.
@CleverFool77 We still have the tabs after building a dropdown right?

jywarren · 2019-07-01T15:40:23Z

Well, you may need to change the functional tests to look for and confirm your new HTML instead of the previous UI HTML... does that make sense?

…

On Mon, Jul 1, 2019 at 11:01 AM Gautami Gupta ***@***.***> wrote: I guess the issue is with the active tabs. That's where the cases are failing. @CleverFool77 <https://github.com/CleverFool77> We still have the tabs after building a dropdown right? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5902?email_source=notifications&email_token=AAAF6J4CGD2MPXKZHKXMV2LP5IL3BA5CNFSM4HYEG7JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY6M6JA#issuecomment-507301668>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J3NEEWOGL4OCOELOLLP5IL3BANCNFSM4HYEG7JA> .

CleverFool77 · 2019-07-03T05:21:24Z

I guess the issue is with the active tabs. That's where the cases are failing.
@CleverFool77 We still have the tabs after building a dropdown right?

Yes but dropdown PR #5925 isn't merged yet.
Maybe your failing is because of divs you added for new UI. I didn't check the tests yet. But it might be.

jywarren · 2019-07-05T15:32:52Z

#5925 is now merged, and 2 other related ones. Hopefully if this is rebased it'll now resolve? Thanks!

jywarren · 2019-07-08T14:13:31Z

Hmm, just checking in with some oddness from automated screenshots (i get them by mail even though they aren't showing here):

partitioning the individual tags page

a379394

CleverFool77 mentioned this pull request Jun 18, 2019

UI Improvements Planning Issue : Individual tags page #5890

Closed

9 tasks

CleverFool77 added this to In progress PRs in UI improvements - Summer Of Code 2019 via automation Jun 19, 2019

CleverFool77 mentioned this pull request Jun 20, 2019

Individual tagpage: Add dropdown to distinct btw info and add test #5925

Merged

adding recent tags

962b64e

Merge branch 'master' into structure_itags

26a0c4b

jywarren mentioned this pull request Jun 28, 2019

The answered and asked tab doesn't work #5958

Closed

gautamig54 closed this Jul 8, 2019

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Jul 8, 2019

gautamig54 reopened this Jul 8, 2019

UI improvements - Summer Of Code 2019 automation moved this from Done to In progress PRs Jul 8, 2019

gautamig54 closed this Jul 8, 2019

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Jul 8, 2019

CleverFool77 moved this from Done to Closed Without Merge ( Not Done) in UI improvements - Summer Of Code 2019 Jul 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Partitioning the individual tags page #5902

Partitioning the individual tags page #5902

gautamig54 commented Jun 14, 2019 •

edited

CleverFool77 commented Jun 14, 2019

gautamig54 commented Jun 14, 2019

gautamig54 commented Jun 14, 2019

gautamig54 commented Jun 14, 2019

CleverFool77 commented Jun 14, 2019 •

edited

gautamig54 commented Jun 14, 2019

CleverFool77 commented Jun 14, 2019

gautamig54 commented Jun 14, 2019

CleverFool77 commented Jun 14, 2019

gautamig54 commented Jun 14, 2019

jywarren commented Jun 18, 2019

gautamig54 commented Jun 19, 2019

CleverFool77 commented Jun 19, 2019

CleverFool77 commented Jun 19, 2019

gautamig54 commented Jun 19, 2019

CleverFool77 commented Jun 19, 2019

jywarren commented Jun 19, 2019 via email

gautamig54 commented Jun 20, 2019

jywarren commented Jun 20, 2019

jywarren commented Jun 20, 2019

gautamig54 commented Jun 21, 2019 •

edited

asquare14 commented Jun 22, 2019

gautamig54 commented Jun 28, 2019

jywarren commented Jun 28, 2019

jywarren commented Jun 28, 2019

jywarren commented Jun 28, 2019

gautamig54 commented Jun 29, 2019

asquare14 commented Jun 29, 2019 •

edited

gautamig54 commented Jul 1, 2019

jywarren commented Jul 1, 2019 via email

CleverFool77 commented Jul 3, 2019

jywarren commented Jul 5, 2019

jywarren commented Jul 8, 2019

Partitioning the individual tags page #5902

Partitioning the individual tags page #5902

Conversation

gautamig54 commented Jun 14, 2019 • edited

CleverFool77 commented Jun 14, 2019

gautamig54 commented Jun 14, 2019

gautamig54 commented Jun 14, 2019

gautamig54 commented Jun 14, 2019

CleverFool77 commented Jun 14, 2019 • edited

gautamig54 commented Jun 14, 2019

CleverFool77 commented Jun 14, 2019

gautamig54 commented Jun 14, 2019

CleverFool77 commented Jun 14, 2019

gautamig54 commented Jun 14, 2019

jywarren commented Jun 18, 2019

gautamig54 commented Jun 19, 2019

CleverFool77 commented Jun 19, 2019

CleverFool77 commented Jun 19, 2019

gautamig54 commented Jun 19, 2019

CleverFool77 commented Jun 19, 2019

jywarren commented Jun 19, 2019 via email

gautamig54 commented Jun 20, 2019

jywarren commented Jun 20, 2019

jywarren commented Jun 20, 2019

gautamig54 commented Jun 21, 2019 • edited

asquare14 commented Jun 22, 2019

gautamig54 commented Jun 28, 2019

jywarren commented Jun 28, 2019

jywarren commented Jun 28, 2019

jywarren commented Jun 28, 2019

gautamig54 commented Jun 29, 2019

asquare14 commented Jun 29, 2019 • edited

gautamig54 commented Jul 1, 2019

jywarren commented Jul 1, 2019 via email

CleverFool77 commented Jul 3, 2019

jywarren commented Jul 5, 2019

jywarren commented Jul 8, 2019

gautamig54 commented Jun 14, 2019 •

edited

CleverFool77 commented Jun 14, 2019 •

edited

gautamig54 commented Jun 21, 2019 •

edited

asquare14 commented Jun 29, 2019 •

edited