New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Improvements Planning Issue : Individual tags page #5890
Comments
I had a few doubts regarding the design. |
@jywarren @CleverFool77 @gauravano @SidharthBansal |
Ohk. Seems like the Issues ave been divided here. So I'll close the earlier issue that I made then. |
The new style guide design looks good but there are many features that we are yet to place in it Like gautami mentioned in the comment.
|
@CleverFool77 I have assigned the tasks to us. You can change it according to your preference. Thanks. |
Hi @gautamig54 do the assignment alternativily. So that it's easier to work and it's faster. |
I'll do it. I will also write the detailed tasks and divide accordingly. |
I have updated the issue. |
I'm not sure regarding sorting @gautamig54 . But that yeah your point does makes sense. As we already distinction based on wikis, questions and notes. |
Hi @gautamig54 Are we going to do this in shadow route or in similar route. |
I am not sure about the shadow page. We are dividing the page into 3 sections. You think that might affect the current page? |
As you can see, the page right now is already divided into two sections. Just divide the second section into columns for cards and maps. |
Hi @gautamig54 Lets wait for @jywarren regarding the shadow or original route. |
Maybe we can manage on the original page itself. Let's wait for @jywarren's views. |
I think given the state of the tag page now (pretty bad) we might as well do this without a shadow page, and that might mean we do things that are going to disrupt, later in the process (like we try to order it so that the things we do first will be an improvement on the current page, rather than do something that'll need a fix later on and leave the page in a broken state) Make sense?
I think we can make the background grey, unless you can think of something else. There are examples of pages in the style guide with no lead image, but then the top box would appear differently. So, let's go with light grey? What do you think? As for the text if there's no wiki page, we might have text like
Perhaps this could go where
Would it go in the left sidebar?
In default view we are seeing all Notes, Questions and Wikis mixed, sorted by recent updates. The sorting area would be different for different pages, so perhaps here we'd offer |
Exciting!!!!! This will be great. We can ask people for input as we go and the new auto screenshots feature can also let us work on this a lot in a set of PRs even before merging. In fact, it should be possible for PRs to be opened against other PR branches, so that we can see the page evolve in the screenshots before doing a larger merge... what do you think? |
Or we can progressively merge PRs into the master branch. Either way. Whatever works for you all! |
This is a good idea. We can start of with improvising the main image display together with the main tag card. This is more like an enhancement.
Light grey sounds good!! Regarding the sub topics, we can add it on the sidebar. Maybe below the related tags? |
Hi @gautamig54 Are you starting off with first part then ? |
Yea, I am beginning with the first part |
So we are not leaving any marginal space for the image? |
You'll be leaving col-2 for map right ?
…On Thu, Jun 13, 2019 at 11:19 PM Gautami Gupta ***@***.***> wrote:
Yea, I am beginning with the first part
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5890?email_source=notifications&email_token=AGLS6STPHT5O5ES6KZVHHXDP2KCCFA5CNFSM4HXV2FR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXUQK6A#issuecomment-501810552>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGLS6SVMUSO6NKTS6MTPN2LP2KCCFANCNFSM4HXV2FRQ>
.
|
I think we can remove it, thanks!
…On Mon, Jul 8, 2019 at 3:27 PM Gautami Gupta ***@***.***> wrote:
Do we need the format toggle options in the new design or we can remove it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5890?email_source=notifications&email_token=AAAF6JZYHA3NTQZDVY4E2Z3P6OIIFA5CNFSM4HXV2FR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZODHUA#issuecomment-509359056>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J2NXSRUTCY46FO7UYTP6OIIFANCNFSM4HXV2FRQ>
.
|
@jywarren here in the design there are a few drop-downs whose purpose I am not able to understand. Like in "Post a question", what will be there in the drop down? |
In Then the dropdown there wouldn't be necessary, and we could just say The other two, I think we can skip, since we have one in the top card. They were just other suggested places to "tuck away" or hide extra functionality! |
@jywarren , So do you want a modal kind of pop up to select the template from? We can even have it as options in drop down. And yes, if we are going with giving user options to select their purpose, we have to change to "Post". |
Hey @gautamig54, we can use dropdown but this design #5890 (comment) looks really great, so can you try to implement it? |
Hi @gautamig54 Are you working on the |
Hi @CleverFool77! I have been a bit busy lately. I am working on the remaining tasks on the tags page. I will push the changes very soon. |
Hi @gautamig54 If you want, I can do the task of Posting a Question ? What do you say ? As I can see you still have some tasks left in other pages. |
What is suppose to be in the dropdown of posting a question? |
Cool. You work on this, I'll start with dashboard then.
In post question dropdown, There should be a modal which would let us
choose template.
@jywarren had added one draft design for it on style guide.
Thanks !!!
…On Sun, Aug 4, 2019 at 10:17 PM Gautami Gupta ***@***.***> wrote:
What is suppose to be in the dropdown of posting a question?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5890?email_source=notifications&email_token=AGLS6ST3JAKPXSV3ZMN2T4TQC4BY3A5CNFSM4HXV2FR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3QFLZY#issuecomment-518018535>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGLS6STF2LBT3RV2FA7QFI3QC4BY3ANCNFSM4HXV2FRQ>
.
|
@gauravano @asquare14 I have a few doubts regarding the options available for the post.
|
Hi @gautamig54 First of all , I don't seem to completely understand your question though, But I'll try to explain whatever I understood. In here, what we are suppossed to have is the modal for choosing between notes, qikis and questions I guess. cc: @gauravano @asquare14 And what you wrote about Issue/story/project and stuff - Instead doing it for And Here one of the main thing to notice is that we won't have be directly posting but rather we should have tag attached for that particular tag as This is posting either Like this which we currently have for posting question for particular tag - |
I implemented what I understood @CleverFool77. I have attached the tags and they working correctly. Except in issues I added the tag, issue-brief-tagname. I think this is how it works. |
Also, @CleverFool77 I was thinking, if we can have a separate issue for correcting the view for the mobile view or tab view. What do you think? |
Hi @gautamig54 Is there need to create more issue ? we can just add this in checklist of follow up fixes and bugs. As If we'll keep on creating issues, we will have lots of issue for every bug. So its better to just checklist them in one existing issue. Cool. |
Sorry to reply slowly here, but i hope it helps clarify - the original
dashboard with the dropdown of options to post is intended to be replaced
by the modal (showing /before/ redirecting to the editor, because which
editor depends on the selection made) because the modal gives us more space
to explain what the different types are for. As it is now, newcomers seeing
the dropdown may not understand easily what each "type" of post is for, so
the modal gives us some space to explain this. Could this work? The modal
could be its own partial template. We'll just want to be sure it renders
nicely in mobile.
…On Thu, Aug 8, 2019 at 2:01 PM Lekhika Dugtal ***@***.***> wrote:
Hi @gautamig54 <https://github.com/gautamig54> Is there need to create
more issue ? we can just add this in checklist of follow up fixes and bugs.
As If we'll keep on creating issues, we will have lots of issue for every
bug. So its better to just checklist the in one existing issue. Cool.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5890?email_source=notifications&email_token=AAAF6J4ELSFTANVA3S6L3ITQDPHBZA5CNFSM4HXV2FR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD32ZXDQ#issuecomment-519412622>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J535HT4GKGYXOQZLQDQDPHBZANCNFSM4HXV2FRQ>
.
|
Cool. @gautamig54 has updated this modal feature in her pr. |
I think we're almost done here too, just need to ensure sorting works! I crossed out a couple we're not doing. |
@CleverFool77 were you interested in wrapping up the sorting issue, or at least breaking it out into a new issue under the same milestone that is a bit more thoroughly documented? Then we can close this out! |
I believe this is almost complete, except for this issue which I'm going to link to! #6307 Thanks all! |
Next we start with the implementation of individual tags page.
Checklist
Show map on the sidebar and people near options @gautamig54Post a question option with dropdown @gautamig54cc : @CleverFool77
The text was updated successfully, but these errors were encountered: