Post your work

[jonxuxu]

Fixes #4194

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

When the user clicks Post your work under the Get Involved tab, a login modal pops up if the user is not logged in.
Gif demo:

I can't demo logging in on the modal because I'm on cloud 9 and the localhost redirect link won't work. But here you can see that when login is completed, the user gets automatically routed to /post .

[plotsbot]

	1 Warning
⚠️	It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!

	2 Messages
📖	@JonathanXu1 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[SidharthBansal]

Fix seems to be correct. But there is some problem on cloud9. I think you can take this task. I will approve it.
Please submit for review on the GCI dashboard

[SidharthBansal]

Hi, changes looks good to me. Thanks for your work.
@gauravano can you please review this and merge this?

[jonxuxu]

Thanks. Can I get a link to the task name?

[SidharthBansal]

try searching post keyword

…

On Mon, Dec 10, 2018 at 12:19 PM Jonathan Xu ***@***.***> wrote: Thanks. Can I get a link to the task name? [image: image] <https://user-images.githubusercontent.com/22998430/49715265-ce49e300-fc1d-11e8-903f-15bd124b0937.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4240 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUACQy-rCD4Do-AcbIjL9gA3U5W4p2v8ks5u3gQAgaJpZM4ZKvMF> .

[jonxuxu]

[SidharthBansal]

https://codein.withgoogle.com/dashboard/tasks/5382165610102784/

[kevinzluo]

@SidharthBansal @JonathanXu1 I was wondering how you managed to get the page to redirect to Post and tried it on my own computer, but it didn't redirect me to Post. I think it does in your gif because the last request was to the Post page.

I think you might need to create an AJAX request like I did in #4239 (the getJSON request`) or modify the return_to.

[SidharthBansal]

Jonathan might help you in this regard

…

On Mon, Dec 10, 2018 at 12:31 PM kevinzluo ***@***.***> wrote: @SidharthBansal <https://github.com/SidharthBansal> @JonathanXu1 <https://github.com/JonathanXu1> I was wondering how you managed to get the page to redirect to Post and tried it on my own computer, but it didn't redirect me to Post. I think it does in your gif because the last request was to the Post page. I think you might need to create an AJAX request like I did in #4239 <#4239> (the getJSON request`) or modify the return_to. [image: shownotworking] <https://user-images.githubusercontent.com/44309027/49715759-04d02f80-fc17-11e8-85cf-a9a13cb4651d.gif> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4240 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUACQzq4CGdNze7_hIu5-cNsl5aCJ4Aqks5u3ga5gaJpZM4ZKvMF> .

[kevinzluo]

@SidharthBansal I was stating that this PR was not redirecting, not my own. Sorry for the confusion.

[jonxuxu]

@kevinzluo hmm thanks for pointing it out. I'm looking into it.

[SidharthBansal]

@JonathanXu1 please provide screenshot for the localhost:3000
The above screenshot is not clear. Also please solve above query asked by @kevinzluo

[jonxuxu]

@SidharthBansal You can click on the gif for a better quality rendering. Do you need another screenshot for something else? I'm using c9 by the way
@kevinzluo is this the line that changes the url and loads the page to a specific link?

anchor.on('click', function() {
      $.getJSON(href);
    });

[SidharthBansal]

@JonathanXu1 can you provide another gif for the behaviour at the localhost?

[jonxuxu]

@SidharthBansal this is what happens when I login with the modal:

Not sure why it works when I login through the login page..

[SidharthBansal]

OK thnx

…

On Mon, Dec 10, 2018, 7:48 PM Jonathan Xu ***@***.*** wrote: @SidharthBansal <https://github.com/SidharthBansal> this is what happens when I login with the modal: [image: ezgif com-video-to-gif] <https://user-images.githubusercontent.com/22998430/49738083-7aaaba00-fc5c-11e8-88ba-59fe128c0ddd.gif> Not sure why it works when I login through the login page.. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4240 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUACQ9azBy4RT5BAv8C3esazul7svPkzks5u3m0tgaJpZM4ZKvMF> .

[grvsachdeva]

@JonathanXu1 see the URL carefully. You are trying to login to localhost from cloud9, it will give error as server is not running at localhost. Makes sense?

[kevinzluo]

Yep that is the line @JonathanXu1 . Sorry for the late reply.

[jonxuxu]

@gauravano I think it has to do with the routing of the login, which would be unnoticeable when testing on localhost. Not sure where to look to fix this issue though..

[grvsachdeva]

Change login route for posting screenshot.

[SidharthBansal]

@JonathanXu1 can you please make your branch consistent with the current master and try out it again.
There might be some deletions and some additions in this pr too. Please send the changes whenever you get time.

[jonxuxu]

Sorry I was working on uni apps. I'm able to look at it now.

I verified that clicking the "post your work button" allows the login modal to show. However, when I login, I cannot verify that the redirect works because the cloud 9 server still redirects to the localhost link.

[kevinzluo]

@JonathanXu1
Try out the changes from #4334 but no need to commit them.

[SidharthBansal]

@JonathanXu1 how is it going ?

[SidharthBansal]

I cannot verify that the redirect works because the cloud 9 server still redirects to the localhost link.

We have solved this issue. You can try again.
Thanks

[SidharthBansal]

@kevinzluo this looks good to me. Can you also review it once? So that I can merge it.
Thanks @JonathanXu1 for the amazing work you are doing at PL.

[jonxuxu]

@SidharthBansal on cloud 9 it is still reloading to localhost. I'm currently installing plots2 on Ubuntu on Windows on another computer. I'll let you know how it goes. Thanks for your patience.

[oorjitchowdhary]

Hi all, after the updates on requireLogin, I think this will work now...
@JonathanXu1 Can you please test out the behaviour?
Thanks

[SidharthBansal]

@jywarren tested it on local host so merging it up.
Thanks all