Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link login modal to 'post your work' under 'Get Involved' tab #4194

Closed
oorjitchowdhary opened this issue Dec 8, 2018 · 16 comments
Closed

Link login modal to 'post your work' under 'Get Involved' tab #4194

oorjitchowdhary opened this issue Dec 8, 2018 · 16 comments
Assignees

Comments

@oorjitchowdhary
Copy link
Member

Link the newly added login modal here at Post your work under the Get Involved tab.

publiclab_adiyenvironme

@jonxuxu
Copy link
Member

jonxuxu commented Dec 10, 2018

I think I've fixed this in #4240. Please let me know if it's good.

@SidharthBansal
Copy link
Member

Issue fixed.

@oorjitchowdhary
Copy link
Member Author

@SidharthBansal I just saw the conversation at #4209 .. I think I haven't credits for creating the issues.. I got rewards for identification which was #4132 .. but I also created #4194 and #4218 and #4120 a while back.. So am I eligible for credits on these issues?

@SidharthBansal
Copy link
Member

Creation of the issues and identification both are included in the same task. You have got credits equally as others have got.
Actually I approved the pr before I asked you to create issues.
I am checking it again. In case I will find any task upon which you were not credited for sure I will link the dashboard task link so that you can review.

@oorjitchowdhary
Copy link
Member Author

Okay thanks a lot 👍 😄

@SidharthBansal
Copy link
Member

Identification and creation of this issue was part of the identication task for which I have already rewarded you.

@SidharthBansal
Copy link
Member

Other people have identified tasks other than the login modal.
Basically the scheme is
1 point for identification of login related taskS with the issue list.
1 point for each task you solve for the login modal
1 point for any other suggestion apart from login modal or any bug
1 point for bug fix
So, if you want more points in these linking tasks, please identify more buttons across the website and sent the pr. I hope you are not angry and it is fair. I paid special attention while giving all of you rewards.

@oorjitchowdhary
Copy link
Member Author

Other people have identified tasks other than the login modal.
Basically the scheme is
1 point for identification of login related taskS with the issue list.
1 point for each task you solve for the login modal
1 point for any other suggestion apart from login modal or any bug
1 point for bug fix

Okay .. I understand

So, if you want more points in these linking tasks, please identify more buttons across the website and sent the pr. I hope you are not angry and it is fair. I paid special attention while giving all of you rewards.

Yes.. I'm not at all angry.. I'm just amazed working with Public Lab 👏

@SidharthBansal
Copy link
Member

https://codein.withgoogle.com/dashboard/tasks/6663508033798144/ here is the task for which you will get rewarded.

@oorjitchowdhary
Copy link
Member Author

Yes .. Just approve my previous so I can claim this

@SidharthBansal
Copy link
Member

Already approved

@oorjitchowdhary
Copy link
Member Author

Oh thank you .. 😄

@oorjitchowdhary
Copy link
Member Author

@SidharthBansal Can I work on this? Or do I have any more pending issues

@SidharthBansal
Copy link
Member

Please check your github linked gmail. If you have completed all other tasks claimed then go for it.
Just I want you to be focussed. Its better to learn a topic then to have overview of all the headings present in the book. Please solve things piece by piece. It will create your job very easy.
You can work on this one!!!
Thanks

@oorjitchowdhary
Copy link
Member Author

Is this getting solved in #4240 ?

@jonxuxu
Copy link
Member

jonxuxu commented Dec 27, 2018

Yeah, I'm just trying to install public lab on my local machine to verify if the routing works. Everything else works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants