Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding post button and modal for template options #6114

Closed
wants to merge 3 commits into from
Closed

Adding post button and modal for template options #6114

wants to merge 3 commits into from

Conversation

gautamig54
Copy link
Contributor

@gautamig54 gautamig54 commented Aug 8, 2019

Fixes #5890 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Screen Shot 2019-08-08 at 11 47 48 AM

Screen Shot 2019-08-08 at 11 47 55 AM

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gautamig54
Copy link
Contributor Author

The modified screenshot :

Screen Shot 2019-08-08 at 12 24 08 PM

Copy link
Member

@CleverFool77 CleverFool77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What;s describe an issue or share a story ?

@CleverFool77
Copy link
Member

Maybe like the template we can lighter grey and the thick border for the templates ?

@gautamig54
Copy link
Contributor Author

I have made a story or a project as a simple post. Whereas issue is the one with tag as issue-brief. I looked at it on the website. https://publiclab.org/wiki/issue-brief

Maybe like the template we can lighter grey and the thick border for the templates ?

Both are of the same color

@gautamig54
Copy link
Contributor Author

Also, there were no font awesome icons as displayed in the style guide. So, I just have put these.
@CleverFool77 You can suggest any other icons? https://fontawesome.com/v4.7.0/icons/

@CleverFool77
Copy link
Member

Hi @gautamig54 I'm in my class right now, I'll go through it in evening. Cool. !!

@gautamig54 gautamig54 closed this Aug 9, 2019
@gautamig54 gautamig54 reopened this Aug 9, 2019
Copy link
Member

@CleverFool77 CleverFool77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gautamig54 Can I have the screenshot of the modal in tab or mobile view ?

@CleverFool77
Copy link
Member

And this modals open towards top. Can we have it in centre ? What do you say ?

@CleverFool77
Copy link
Member

Though this one is clip-board but would look cool is story too I guess
https://fontawesome.com/v4.7.0/icon/clipboard
What do you say ?

@gautamig54
Copy link
Contributor Author

Hi @gautamig54 Can I have the screenshot of the modal in tab or mobile view ?

About that, I am not sure how to display that. I can change it to vertical modal but then it will occupy the entire screen. How do you think we can do this, because there is no design for the modal in the mobile view.
cc : @jywarren

@gautamig54
Copy link
Contributor Author

And this modals open towards top. Can we have it in centre ? What do you say ?

I'll do that! Thanks!

Copy link
Member

@CleverFool77 CleverFool77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess vertical one would look good for mobile !! try having vertical one.
OR else having a square modal ? and left/right arrows to move forward and backward ??

@jywarren
Copy link
Member

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
3 Messages
📖 @gautamig54 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.
📖 #
Screenshots 📸 (click to expand)

6114-test_viewing_question_post.png

6114-test_wiki.png

6114-test_tag_page.png

6114-test_blog_page_with_location_modal.png

6114-test_login.png

6114-test_wiki_page_with_inline_grids.png

6114-test_questions.png

6114-test_methods.png

6114-test_tag_by_author_page.png

6114-test_viewing_the_dropdown_menu.png

6114-test_viewing_the_settings_page.png

6114-test_comments.png

6114-test_stats.png

6114-test_tags.png

6114-test_people.png

6114-test_front.png

6114-test_signup.png

6114-test_questions_shadow.png

6114-test_blog.png

6114-test_question_page.png

6114-test_front_page_with_navbar_search_autocomplete.png

6114-test_viewing_the_dashboard.png

Learn about automated screenshots

Generated by 🚫 Danger

@jywarren
Copy link
Member

Just noting i got tests to pass now! :-)

@jywarren
Copy link
Member

Also we could use things like this if we attribute properly: https://thenounproject.com/search/?q=clipboard

Would we be able to have a link like "Read more about templates" and "Skip using a template" as two links below the 3 options? The first could go to /templates, and the second to just /post. What do you think?

@gautamig54
Copy link
Contributor Author

Also we could use things like this if we attribute properly: https://thenounproject.com/search/?q=clipboard

Would we be able to have a link like "Read more about templates" and "Skip using a template" as two links below the 3 options? The first could go to /templates, and the second to just /post. What do you think?

Yes, we can add the links here. Also, @jywarren can you suggest us the mobile/tab view for this modal?

@jywarren
Copy link
Member

In mobile, maybe we stack vertically? Let's just be sure more than one appear per "screen" so people know there are options. Thanks!

@jywarren
Copy link
Member

Hi! How does this sound to folks? Thanks!

@gautamig54
Copy link
Contributor Author

Hi @jywarren! I am trying the vertical modal!

@gautamig54
Copy link
Contributor Author

Regarding the /templates, it will be a wiki page?

@gautamig54
Copy link
Contributor Author

gautamig54 commented Aug 24, 2019

The updates design is :

Screen Shot 2019-08-24 at 5 22 08 PM

I am working on mobile view.

@jywarren
Copy link
Member

Regarding the /templates, it will be a wiki page?

Yes! I think it already is. This looks like it needs a conflict resolution but is looking great! Can we add a few words on how to trigger this? I.e. if we want it to appear on tag cards, for example, could we trigger it from there?

@SidharthBansal
Copy link
Member

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it.
Thanks for contributing on Public Lab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Improvements Planning Issue : Individual tags page
4 participants