New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding post button and modal for template options #6114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What;s describe an issue or share a story ?
Maybe like the template we can lighter grey and the thick border for the templates ? |
I have made a story or a project as a simple post. Whereas issue is the one with tag as issue-brief. I looked at it on the website. https://publiclab.org/wiki/issue-brief
Both are of the same color |
Also, there were no font awesome icons as displayed in the style guide. So, I just have put these. |
Hi @gautamig54 I'm in my class right now, I'll go through it in evening. Cool. !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gautamig54 Can I have the screenshot of the modal in tab or mobile view ?
And this modals open towards top. Can we have it in centre ? What do you say ? |
Though this one is |
About that, I am not sure how to display that. I can change it to vertical modal but then it will occupy the entire screen. How do you think we can do this, because there is no design for the modal in the mobile view. |
I'll do that! Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess vertical one would look good for mobile !! try having vertical one.
OR else having a square modal ? and left/right arrows to move forward and backward ??
Screenshots 📸 (click to expand)6114-test_viewing_question_post.png6114-test_wiki.png6114-test_tag_page.png6114-test_blog_page_with_location_modal.png6114-test_login.png6114-test_wiki_page_with_inline_grids.png6114-test_questions.png6114-test_methods.png6114-test_tag_by_author_page.png6114-test_viewing_the_dropdown_menu.png6114-test_viewing_the_settings_page.png6114-test_comments.png6114-test_stats.png6114-test_tags.png6114-test_people.png6114-test_front.png6114-test_signup.png6114-test_questions_shadow.png6114-test_blog.png6114-test_question_page.png6114-test_front_page_with_navbar_search_autocomplete.png6114-test_viewing_the_dashboard.pngLearn about automated screenshots Generated by 🚫 Danger |
Just noting i got tests to pass now! :-) |
Also we could use things like this if we attribute properly: https://thenounproject.com/search/?q=clipboard Would we be able to have a link like "Read more about templates" and "Skip using a template" as two links below the 3 options? The first could go to |
Yes, we can add the links here. Also, @jywarren can you suggest us the mobile/tab view for this modal? |
In mobile, maybe we stack vertically? Let's just be sure more than one appear per "screen" so people know there are options. Thanks! |
Hi! How does this sound to folks? Thanks! |
Hi @jywarren! I am trying the vertical modal! |
Regarding the |
Yes! I think it already is. This looks like it needs a conflict resolution but is looking great! Can we add a few words on how to trigger this? I.e. if we want it to appear on tag cards, for example, could we trigger it from there? |
As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it. |
Fixes #5890 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!