Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for reviewers and co-reviewing workflow ⚡️ #4707

Open
jywarren opened this issue Jan 24, 2019 · 35 comments
Open

Call for reviewers and co-reviewing workflow ⚡️ #4707

jywarren opened this issue Jan 24, 2019 · 35 comments
Labels
outreach issues involve community involvement and helping people who're stuck somewhere review-me support

Comments

@jywarren
Copy link
Member

Building on the process we developed in publiclab/image-sequencer#656, I'd like to propose an improved collaborative workflow for co-reviewing new code in the plots2 project. We've had some great success trying this out at image-sequencer, and although we already do a lot of co-reviewing here in the plots2 project, I also think we could share the responsibility even more!

Community growth

This is especially important as our community has grown so much in the past few months!

Check out some of these pages to see how many people have helped build plots2, since we really started doing welcoming and outreach ~2 years ago:

What's next: co-review workflow

To build on this community strength 🤝, we'd like to ask for people to sign up as reviewers, to help get pull requests ready for merging. In the new workflow, we'd like each PR to have:

  • ✅ 2 reviews by people from the @publiclab/plots2-reviewers group
  • ✅ a ready label, once ready for final review by someone with merge permissions (currently @SidharthBansal, @gauravano, and I, although we are interested in expanding this group soon)
  • ✅ tests if possible (not mandatory but preferred) with each PR - although for first-timers this is less critical.

This doesn't mean that we should stop helping each other solve problems even if we're not in the reviewers group -- i've seen a lot of great welcoming and cooperation! But at least we'll be able to get things ready and merged faster. 👍 🙌

Reviewers team

So, this new @publiclab/plots2-reviewers team -- we'd like to ask folks to join it if you're interested! Many of you already play this role -- THANK YOU! 🎉 We'd like folks to consider, as a prerequisite to joining:

  • ✅ having 2 PRs merged
  • ✅ having helped someone else troubleshoot a PR or issue
  • ✅ having made a first-timers-only issue and welcomed in a new person to make their own first contribution (this is how our community grows!)

If you've completed these, please ask here and we'll be sure to add you the new reviewers group. You'll get notifications when people request a review from you, or mention @publiclab/plots2-reviewers.

Also, we should welcome reviews by folks not in the reviewers group, of course! This will be a group to help coordinate co-reviews, but it's not meant to be exclusive. And we should encourage people to join!

Managing too many emails!

Just a note - your inbox can become quite a mess as the community grows! Consider turning off notifications for /every event/ and just listening to if you're mentioned! 📬

THANK YOU for making this part of the Public Lab coding community a warm, welcoming, and wonderful place!!! ⚡️ 🙌 👍 🎉 🎉 🎉

@jywarren jywarren added outreach issues involve community involvement and helping people who're stuck somewhere review-me labels Jan 24, 2019
@jywarren
Copy link
Member Author

Also, @publiclab/reviewers (our older group we are revising!) please check this out!

@sagarpreet-chadha
Copy link
Contributor

Count me in :) !

@oorjitchowdhary
Copy link
Member

I'm in... :))
I've completed the prerequisites..

@jywarren
Copy link
Member Author

@sashadev-sky - maybe you'd be interested? I know @Paarmita has been really helpful on this kind of activity as well although haven't seen you in a little while, but do tell us if you're interested! Thanks all! 🎉

@sashadev-sky
Copy link
Member

@jywarren Thank you for mentioning me, I would love to join the group 👍

@jywarren
Copy link
Member Author

Great! I'll add you shortly. Also I was wondering if @cesswairimu had any interest? And to be clear this reviewing responsibility is one we plan to share so there's no need to be worried about having to do lots of reviews if you don't have time. Each person can participate to the extent of their willingness and time available and we're grateful for your teamwork!

@namangupta01
Copy link
Member

namangupta01 commented Jan 29, 2019 via email

@SidharthBansal
Copy link
Member

SidharthBansal commented Jan 30, 2019 via email

@grvsachdeva
Copy link
Member

Sidharth, you were already in the group when it formed 😄

@SidharthBansal
Copy link
Member

SidharthBansal commented Jan 31, 2019 via email

@jywarren
Copy link
Member Author

jywarren commented Feb 5, 2019

@asquare14 did you want to join in as a reviewer? Thanks for all your help as a mentor!

@jywarren
Copy link
Member Author

jywarren commented Feb 5, 2019

Hi, folks, just wanted to say that I've also been trying to close out older more urgent issues by breaking some of these out and recruiting into them from the weekly check-ins; esp with some people shifting over to MapKnitter, i'm interested in doing a good job to wrap up long-open projects at PublicLab so we feel more confident starting new projects. Sometimes it's hard to really check something totally off the list!

https://github.com/publiclab/plots2/labels/priority

@harshithpabbati
Copy link

@jywarren Can I be a part of reviewers team..

@grvsachdeva
Copy link
Member

grvsachdeva commented Feb 18, 2019

Hey @harshithpabbati, can you paste the links to the PRs, issues here as I can't find your PRs on plots2? Thanks!

@harshithpabbati
Copy link

harshithpabbati commented Feb 18, 2019

@grvsachdeva
Copy link
Member

These are pre-requisite to join the @publiclab/plots2-reviewers group:

prerequisite_plots2

@harshithpabbati
Copy link

So do i need to create a first timers issue??
@gauravano

@grvsachdeva
Copy link
Member

you need to do all the three tasks for the plots2 repo.

@IshaGupta18
Copy link
Collaborator

Count me in! 🎉

@CleverFool77
Copy link
Member

Me 🙋‍♀️. It's Lekhika here.
I guess I have completed the prerequisites given in issue required to be a reviewer. 🤔
Is there anything else which is required?

@grvsachdeva
Copy link
Member

@IshaGupta18 added you

@IshaGupta18
Copy link
Collaborator

Thank you @gauravano 🎉

@grvsachdeva
Copy link
Member

@CleverFool77 added you too.

@ananyaarun
Copy link
Member

Can i be a part of this team ?
Guess I have completed the prerequisites :)

@grvsachdeva
Copy link
Member

Added you @ananyaarun!

@jywarren
Copy link
Member Author

jywarren commented Mar 25, 2019 via email

@divyabaid16
Copy link
Contributor

Hey!!
I have completed all the prerequisites. Can I be added to this group?
Thanks!

@jywarren jywarren changed the title Call for reviewers group and new co-reviewing workflow ⚡️ Call for reviewers and co-reviewing workflow ⚡️ Apr 21, 2019
@jainaman224
Copy link
Contributor

I have completed the prerequisites. Please add me to the group.

@gautamig54
Copy link
Contributor

@jywarren @gauravano I guess I have completed all the prerequisites required to be a part of this group. I would love to help new contributors in their issues and PRs and also reviewing them.
Kindly add me to this group.
Thanks!

@grvsachdeva
Copy link
Member

Hi @divyabaid16 @jainaman224 @gautamig54 added you all to the @publiclab/plots2-reviewers 🎉 👍

Thanks!

@pydevsg
Copy link
Member

pydevsg commented Nov 21, 2019

@gauravano , @jywarren I have completed all the steps. I would love to help beginners in their PRs by reviewing them. Please add me in the group too.

@jywarren
Copy link
Member Author

Done! Thank you!!!

@SidharthBansal
Copy link
Member

@VladimirMikulic @Uzay-G are interested I guess

@SidharthBansal
Copy link
Member

@cesswairimu @jywarren can you please add these folks

@VladimirMikulic
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreach issues involve community involvement and helping people who're stuck somewhere review-me support
Projects
None yet
Development

No branches or pull requests