Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update settings.html.erb translation line #9367

Merged
merged 1 commit into from Mar 29, 2021
Merged

Conversation

Onihani
Copy link
Contributor

@Onihani Onihani commented Mar 23, 2021

small change made

Fixes #9361

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

small change made
@Onihani Onihani requested a review from a team as a code owner March 23, 2021 23:16
@welcome
Copy link

welcome bot commented Mar 23, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Mar 23, 2021

@codeclimate
Copy link

codeclimate bot commented Mar 23, 2021

Code Climate has analyzed commit 83d5953 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@c188b97). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head a26b5cf differs from pull request most recent head 83d5953. Consider uploading reports for the commit 83d5953 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9367   +/-   ##
=======================================
  Coverage        ?   81.48%           
=======================================
  Files           ?       98           
  Lines           ?     5930           
  Branches        ?        0           
=======================================
  Hits            ?     4832           
  Misses          ?     1098           
  Partials        ?        0           

@Onihani
Copy link
Contributor Author

Onihani commented Mar 24, 2021

@RuthNjeri please review my pull request

@RuthNjeri
Copy link
Contributor

Hi @Onihani, which issue is this issue fixing? Please add the issue number on the description of the Pull Request, it will help us know what the fix is for. Thank you.

@Onihani
Copy link
Contributor Author

Onihani commented Mar 25, 2021

@RuthNjeri I just added the issue number

@pydevsg
Copy link
Member

pydevsg commented Mar 26, 2021

@Onihani seems like you have added PR Issue no. instead of Issue No.
Please fix it.
Also, please add a screenshot to the UI change if any .

@Onihani
Copy link
Contributor Author

Onihani commented Mar 26, 2021

Thanks @pydevsg, I just updated to the issue number

@pydevsg
Copy link
Member

pydevsg commented Mar 26, 2021

Cool

@Onihani
Copy link
Contributor Author

Onihani commented Mar 27, 2021

Hi please can someone review my pull request

Copy link
Contributor

@RuthNjeri RuthNjeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @Onihani and for the reviews @pydevsg 🎉

@RuthNjeri
Copy link
Contributor

Not sure why I am unable to merge this PR... but I have added the ready to merge label.

@Onihani
Copy link
Contributor Author

Onihani commented Mar 28, 2021

Not sure why I am unable to merge this PR... but I have added the ready to merge label.

@RuthNjeri Can i create a new pull request for the issue

@jywarren jywarren changed the title Update settings.html.erb Update settings.html.erb translation line Mar 29, 2021
@jywarren
Copy link
Member

Hi @RuthNjeri i think perhaps it requires 2 approvals? We can adjust that if it's coming up a lot, or if you're able to ask someone else in the chatroom to review, there's a relatively large group of people who can, and we can also recruit more reviewers in #9032 or #4707 maybe.

Or, because this PR probably doesn't need extra reviewing, we could ease the rules and decide we can bypass the 2 reviewers rule for some PRs!

Thanks!!!

@jywarren jywarren merged commit 2c0a624 into publiclab:main Mar 29, 2021
@welcome
Copy link

welcome bot commented Mar 29, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

Thanks @Onihani for your contribution, this looks great!!!

@RuthNjeri
Copy link
Contributor

Thanks, @jywarren, I think for now, we can leave it as it is... since I can approve it and add the ready to merge label. If I keep encountering it, we can circle back to adding more reviewers or easing the rules.

No need for another PR @Onihani , thanks for helping us out 🎉

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small change to notifications settings page to remove extra + character
4 participants