New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update settings.html.erb translation line #9367
Conversation
small change made
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 83d5953 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #9367 +/- ##
=======================================
Coverage ? 81.48%
=======================================
Files ? 98
Lines ? 5930
Branches ? 0
=======================================
Hits ? 4832
Misses ? 1098
Partials ? 0 |
@RuthNjeri please review my pull request |
Hi @Onihani, which issue is this issue fixing? Please add the issue number on the description of the Pull Request, it will help us know what the fix is for. Thank you. |
@RuthNjeri I just added the issue number |
@Onihani seems like you have added PR Issue no. instead of Issue No. |
Thanks @pydevsg, I just updated to the issue number |
Cool |
Hi please can someone review my pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why I am unable to merge this PR... but I have added the |
@RuthNjeri Can i create a new pull request for the issue |
Hi @RuthNjeri i think perhaps it requires 2 approvals? We can adjust that if it's coming up a lot, or if you're able to ask someone else in the chatroom to review, there's a relatively large group of people who can, and we can also recruit more reviewers in #9032 or #4707 maybe. Or, because this PR probably doesn't need extra reviewing, we could ease the rules and decide we can bypass the 2 reviewers rule for some PRs! Thanks!!! |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Thanks @Onihani for your contribution, this looks great!!! |
small change made
small change made
small change made
Fixes #9361
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!