Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog's page read-more button implemented #5449

Merged
merged 1 commit into from Apr 21, 2019

Conversation

divyabaid16
Copy link
Contributor

Fixes #5352 (<=== Add issue number here)

GIF for the change:
Peek 2019-04-10 23-31

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@plotsbot
Copy link
Collaborator

1 Message
📖 @divyabaid16 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@divyabaid16
Copy link
Contributor Author

@jywarren how does this look?

@divyabaid16
Copy link
Contributor Author

@gauravano @jywarren can you please review this?
And how do I get the label rights so that I can add review me label to the PRs?

@grvsachdeva
Copy link
Member

Hi @divyabaid16, I think @publiclab/plots2-reviewers have that access and some other people. If you like to join reviewers team then comment here - #4707

Thanks!

Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice work @divyabaid16!

@grvsachdeva grvsachdeva merged commit 90e83e5 into publiclab:master Apr 21, 2019
@grvsachdeva
Copy link
Member

Merged 🎉 👍

@divyabaid16 divyabaid16 deleted the blog2-read-more branch April 21, 2019 17:02
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
digitaldina pushed a commit to digitaldina/plots2 that referenced this pull request May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog redesign next steps and discussion
4 participants