Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11540: Picklist trigger input changes on transfer #11543

Merged
merged 4 commits into from Mar 4, 2024

Conversation

melloware
Copy link
Member

Fix #11540: Picklist trigger input changes on transfer

@melloware melloware added the enhancement Additional functionality to current component label Feb 29, 2024
@melloware
Copy link
Member Author

Thanks!

@jepsar
Copy link
Member

jepsar commented Mar 1, 2024

Shouldn't this be added to the docs?

@tandraschko
Copy link
Member

if "transfer" triggers onchange, "reorder" should to
so it means if a user needs different listeners he uses transfer+reordern, change catches both

@BalusC
Copy link

BalusC commented Mar 1, 2024

You could trigger a namespaced event.

@melloware
Copy link
Member Author

PR updated not sure if that is what you guys had in mind but change triggers on reorder or transfer and updated the migration guide.

@jepsar
Copy link
Member

jepsar commented Mar 1, 2024

I was thinking of https://github.com/primefaces/primefaces/blob/master/docs/14_0_0/components/picklist.md#ajax-behavior-events not sure if we should mention this there.

@melloware
Copy link
Member Author

Hmm this just triggers the client side change events on the input but doesn't send an AJAX change event. However I did realize that no defaultEvent was defined on this component and there should be so I made it transfer

@melloware melloware merged commit c4ed952 into primefaces:master Mar 4, 2024
10 checks passed
@melloware melloware deleted the PF11540 branch March 4, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additional functionality to current component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PickList: fire 'change' event
5 participants