Fix #11540: Picklist trigger input changes on transfer (#11543)

* Fix #11540: Picklist trigger input changes on transfer * Update primefaces/src/main/resources/META-INF/resources/primefaces/picklist/picklist.js * Fix #11540: Picklist trigger input changes on transfer * Fix #11540: Picklist trigger input changes on transfer --------- Co-authored-by: Jasper de Vries <jepsar@gmail.com>
primefaces · Mar 4, 2024 · c4ed952 · c4ed952
1 parent 6a543d6
commit c4ed952
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 0 deletions.
diff --git a/docs/14_0_0/components/picklist.md b/docs/14_0_0/components/picklist.md
@@ -187,13 +187,19 @@ to _onTransfer_ attribute.
 
 ## Ajax Behavior Events
 
+The following AJAX behavior events are available for this component. If no event is specified the default event is called.  
+
+**Default Event:** `transfer`  
+**Available Events:** `reorder, select, transfer, unselect`  
+
 | Event | Listener Parameter | Fired |
 | --- | --- | --- |
 select | org.primefaces.event.SelectEvent | When an item selected.
 unselect | org.primefaces.event.UnselectEvent | When an item unselected.
 reorder | javax.faces.event.AjaxBehaviorEvent | When list is reordered.
 transfer | org.primefaces.event.TransferEvent | When an item is moved to another list.
 
+
 ```xhtml
 <p:pickList value="#{pickListBean.cities}" var="city" itemLabel="#{city}" itemValue="#{city}">
     <p:ajax event="transfer" listener="#{pickListBean.handleTransfer}" />

diff --git a/docs/migrationguide/14_0_0.md b/docs/migrationguide/14_0_0.md
@@ -89,6 +89,7 @@ Few selection attributes have been renamed for consistency purposes:
 
 ## PickList
   * `addLabel, addAllLabel, removeLabel, removeAllLabel, moveUpLabel,  moveTopLabel, moveDownLabel,  moveBottomLabel` properties have been moved to client side locale
+  * `transfer` and `reorder` events now fire `change` events on the source and target inputs to make it consistent with other inputs
 
 ## SelectOneRadio
 

diff --git a/primefaces/src/main/java/org/primefaces/component/picklist/PickList.java b/primefaces/src/main/java/org/primefaces/component/picklist/PickList.java
@@ -104,6 +104,11 @@ public Collection<String> getEventNames() {
         return EVENT_NAMES;
     }
 
+    @Override
+    public String getDefaultEventName() {
+        return "transfer";
+    }
+
     @Override
     protected void validateValue(FacesContext facesContext, Object newValue) {
         super.validateValue(facesContext, newValue);

diff --git a/primefaces/src/main/resources/META-INF/resources/primefaces/picklist/picklist.js b/primefaces/src/main/resources/META-INF/resources/primefaces/picklist/picklist.js
@@ -1163,6 +1163,8 @@ PrimeFaces.widget.PickList = PrimeFaces.widget.BaseWidget.extend({
             $($this.jqId + ' ul').sortable('enable');
             $this.updateButtonsState();
         }
+
+        this.fireInputChanged();
     },
 
     /**
@@ -1224,6 +1226,17 @@ PrimeFaces.widget.PickList = PrimeFaces.widget.BaseWidget.extend({
      */
     fireReorderEvent: function() {
         this.callBehavior('reorder');
+        this.fireInputChanged();
+    },
+
+    /**
+     * Triggers change events on the input fields.
+     * @private
+     */
+    fireInputChanged: function() {
+        // #11540: trigger change events on inputs for form handling
+        this.targetInput.trigger("change");
+        this.sourceInput.trigger("change");
     },
 
     /**