New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issues with save function #276
Conversation
python-version: "3.12" | ||
- name: Install dependencies | ||
run: | | ||
pip install -e '.[extra]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just run pip install pandas
for now after this, since we need it for the datasets
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
- Coverage 81.72% 81.71% -0.01%
==========================================
Files 41 41
Lines 4323 4321 -2
==========================================
- Hits 3533 3531 -2
Misses 790 790 ☔ View full report in Codecov by Sentry. |
This fails with:
Probably because Firefox is run in non-headless mode: https://stackoverflow.com/questions/46809135/webdriver-exceptionprocess-unexpectedly-closed-with-status-1 Now, technically it runs in headless mode on my system but the resulting image is incorrect (only gives correct image output when not run in headless mode). |
I suppose we could instead run with chrome using: https://github.com/browser-actions/setup-chrome. |
Ah, dang--what does the image look like? It looks there are options to run FF headless in that SO post and this one, so I'm curious if there's a way to get it to work?! |
Seems like |
With |
|
This adds a workflow job that tests whether the
.save()
method is properly producing a table image when using the"firefox"
webdriver.Also fixes: #241