ci: test on a windows runner #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
==========================================
- Coverage 81.71% 81.71% -0.01%
==========================================
Files 41 41
Lines 4321 4320 -1
==========================================
- Hits 3531 3530 -1
Misses 790 790 ☔ View full report in Codecov by Sentry. |
machow
changed the title
|
Okay, the remaining test failures are all related to paths in our fmt_image snapshot tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses potential issues when using
GT.save()on a windows machine. It removes an unnecessary tmp dir being used when initiating NamedTemporaryFile (which could cause bizarreness), and adds a windows runner to our CI.Edit: let's push fine-tuning to #276, which uploads saved table images as artifacts in our CI.