Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rpc v2 types and api #1427

Merged

Conversation

koushiro
Copy link
Collaborator

  • add rpc v2 types
  • add rpc v2 api

@boundless-forest
Copy link
Collaborator

I compared some key structs with Geth, The PR is only about the v2 api methods and types, LGTM. However, I am a bit worried about whether the v2 api implementation next will introduce some uncompatibility with the v1 version. It may require the client node resync the db or there is a migration solution.

@koushiro
Copy link
Collaborator Author

koushiro commented May 28, 2024

However, I am a bit worried about whether the v2 api implementation next will introduce some uncompatibility with the v1 version. It may require the client node resync the db or there is a migration solution.

RPC API is a standalone layer, the compatibility issues like node resync and db migration that you consider should be limited to the implementation of db and mapping-sync level.

Personally, I prefer to provide a mapping abstraction layer under the RPC API layer to manage the mapping of substrate data and ethereum data.

@boundless-forest boundless-forest merged commit 5f13853 into polkadot-evm:master May 28, 2024
4 checks passed
@koushiro koushiro deleted the refactor-rpc-part1 branch May 28, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants