Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RPC implementation #1336

Open
koushiro opened this issue Mar 12, 2024 · 4 comments
Open

Refactor RPC implementation #1336

koushiro opened this issue Mar 12, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@koushiro
Copy link
Collaborator

koushiro commented Mar 12, 2024

Motivation

I am not very satisfied with the current RPC implementation (due to some unreadable implementation and some compatibility issues), so I plan to refactor this part.

Suggested Solution

  1. Refactor the rpc parameter and return value types, which will be fully compatible with the ethereum standard (non-standard RPC will be compatible with geth) feat: add rpc v2 types and api #1427
  2. Refactor rpc api according to the namespace. feat: add rpc v2 types and api #1427
  3. Refactor rpc implementation.

Additional Information

eip-4844 is not currently planned to be supported (need evm to support it first)

@koushiro koushiro added the enhancement New feature or request label Mar 12, 2024
@koushiro koushiro self-assigned this Mar 12, 2024
@deblanco
Copy link

deblanco commented Apr 2, 2024

@koushiro +1 to the EIP-4844
Any news?

@koushiro
Copy link
Collaborator Author

koushiro commented Apr 2, 2024

@koushiro +1 to the EIP-4844 Any news?

We need evm to support EIP-4844 first

@boundless-forest
Copy link
Collaborator

We need evm to support EIP-4844 first

We'd better to upgrade the frontier evm version to the latest of evm crates, 1.0.

@koushiro
Copy link
Collaborator Author

koushiro commented May 13, 2024

I have completed rewriting the RPC types and API parts (#1427), but the specific implementation of RPC still depends on other client components, whose implementation is not satisfactory to me.
Therefore, before implementing RPC, I will likely rewrite these components, like db, mapping-sync...

@koushiro koushiro pinned this issue May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants