Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] breaking: do not throw promises #813

Merged
merged 8 commits into from
Nov 12, 2023
Merged

[v2] breaking: do not throw promises #813

merged 8 commits into from
Nov 12, 2023

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Nov 10, 2023

The first step for #810

We need the React canary version for testing with use().

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 3:23am

Copy link

codesandbox-ci bot commented Nov 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 03cd68a:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration

@dai-shi dai-shi mentioned this pull request Nov 10, 2023
Merged
15 tasks
Copy link

github-actions bot commented Nov 10, 2023

Size Change: -721 B (-1%)

Total Size: 50.5 kB

Filename Size Change
dist/esm/react.js 715 B -17 B (-2%)
dist/esm/vanilla.js 2.32 kB -116 B (-5%)
dist/react.js 657 B -11 B (-2%)
dist/system/react.development.js 851 B -20 B (-2%)
dist/system/react.production.js 459 B -12 B (-3%)
dist/system/vanilla.development.js 2.46 kB -120 B (-5%)
dist/system/vanilla.production.js 1.44 kB -83 B (-5%)
dist/umd/react.development.js 801 B -13 B (-2%)
dist/umd/react.production.js 520 B -6 B (-1%)
dist/umd/vanilla.development.js 2.63 kB -124 B (-4%)
dist/umd/vanilla.production.js 1.56 kB -79 B (-5%)
dist/vanilla.js 2.51 kB -120 B (-5%)
ℹ️ View Unchanged
Filename Size
dist/esm/index.js 62 B
dist/esm/macro.js 698 B
dist/esm/macro/vite.js 864 B
dist/esm/react/utils.js 225 B
dist/esm/utils.js 68 B
dist/esm/vanilla/utils.js 3.07 kB
dist/index.js 243 B
dist/macro.js 919 B
dist/macro/vite.js 1.08 kB
dist/react/utils.js 244 B
dist/system/index.development.js 236 B
dist/system/index.production.js 170 B
dist/system/macro.development.js 779 B
dist/system/macro.production.js 556 B
dist/system/macro/vite.development.js 951 B
dist/system/macro/vite.production.js 660 B
dist/system/react/utils.development.js 321 B
dist/system/react/utils.production.js 223 B
dist/system/utils.development.js 241 B
dist/system/utils.production.js 176 B
dist/system/vanilla/utils.development.js 3.28 kB
dist/system/vanilla/utils.production.js 2.19 kB
dist/umd/index.development.js 382 B
dist/umd/index.production.js 330 B
dist/umd/macro.development.js 1.03 kB
dist/umd/macro.production.js 721 B
dist/umd/macro/vite.development.js 1.23 kB
dist/umd/macro/vite.production.js 879 B
dist/umd/react/utils.development.js 400 B
dist/umd/react/utils.production.js 299 B
dist/umd/utils.development.js 398 B
dist/umd/utils.production.js 344 B
dist/umd/vanilla/utils.development.js 3.86 kB
dist/umd/vanilla/utils.production.js 2.46 kB
dist/utils.js 247 B
dist/vanilla/utils.js 3.71 kB

compressed-size-action

@dai-shi dai-shi merged commit 2c33752 into v2 Nov 12, 2023
33 checks passed
@dai-shi dai-shi deleted the breaking/for-v2-step1 branch November 12, 2023 11:38
dai-shi added a commit that referenced this pull request May 15, 2024
* prepare for the next major version

* [v2] breaking: do not throw promises (#813)

* [v2] breaking: do not throw promises

* use use

* fix CI hopefully

* fix CI hopefully 2

* fix CI hopefully 3

* fix CI hopefully 4

* fix CI hopefully 5

* any type for simplicity

* [v2] breaking: do not copy initial objects (#815)

* [v2] breaking: do not copy initial objects

* fix deepClone

* refactor

* ah we need it

* deep clone

* minor fix

* breaking: require TS 4.5 at least (#817)

* TS minimal requirement v4.5

* wip: test old ts

* remove downlevel-dts

* simplify test

* simplify test 2

* simplify test 3

* wip: useMaybePromise

* wip: useMaybePromise 2

* wip: useMaybePromise 3

* rename back

* [v2] breaking: drop "module" condition (#818)

* run prettier

* [v2] breaking: require react 18 and drop use-sync-external-store (#819)

* [v2] breaking: require react 18 and drop use-sync-external-store

* drop tests pre react 18

* wip: cannot use react 17 for prd test

* drop production test which is impossible

* esm?

* fix regex

* fix sed

* [v2] breaking: remove deprecated features (#820)

* remove depreacated useProxy macro

* revert plugin-transform

* remove two more babel packages

* revert babel core

* remove proxyWithComputed

* remove addComputed

* remove devtools deprecated option

* [v2] breaking: remove derive-valtio dependency (#821)

* [v2] breaking: drop UMD/SystemJS builds and simplify babel config (#822)

* [v2] breaking: drop UMD/SystemJS builds and simplify babel config

* format

* 2.0.0-alpha.0

* run prettier

* 2.0.0-alpha.1

* simplify ts test script

* update react canary version

* remove depreacated proxyWithHistory

* 2.0.0-alpha.2

* update react canary

* [v2] export Snapshot type (#856)

* 2.0.0-beta.0

* [v2] drop es5 (#865)

* breaking: compatibility with memo (#866)

* update yarn lock

* 2.0.0-beta.1

* [v2] fix: make affected per proxy (#868)

* 2.0.0-beta.2

* [v2] fix rollup config for cjs (#873)

* 2.0.0-beta.3

* [v2] migration guide (#878)

* fix workflow file

* fix: explicit package.json type field (#882)

* 2.0.0-beta.4

* fix(react): Change to useLayoutEffect in useSnapshot (#891)

* Address spurious consistency check re-renders by using useLayoutEffect inside useSnapshot instead of useEffect

* Move regression tests for useSnapshot perf improvement to optimization test file

* Update tests/optimization.test.tsx

---------

Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>

* 2.0.0-beta.5

* chore package.json

---------

Co-authored-by: Christopher Swasey <christopher.swasey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant