Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 #810

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

v2 #810

wants to merge 44 commits into from

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Nov 6, 2023

Related Issues or Discussions

#703

Tasks

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2024 0:28am

Copy link

codesandbox-ci bot commented Nov 6, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented Nov 6, 2023

Size Change: -54.5 kB (-90%) 🏆

Total Size: 6.18 kB

Filename Size Change
dist/esm/index.js 0 B -62 B (removed) 🏆
dist/esm/macro.js 0 B -698 B (removed) 🏆
dist/esm/macro/vite.js 0 B -864 B (removed) 🏆
dist/esm/react.js 0 B -732 B (removed) 🏆
dist/esm/react/utils.js 0 B -258 B (removed) 🏆
dist/esm/utils.js 0 B -68 B (removed) 🏆
dist/esm/vanilla.js 0 B -2.44 kB (removed) 🏆
dist/esm/vanilla/utils.js 0 B -3.17 kB (removed) 🏆
dist/macro.js 0 B -919 B (removed) 🏆
dist/macro/vite.js 0 B -1.08 kB (removed) 🏆
dist/react.js 663 B -5 B (-1%)
dist/system/index.development.js 0 B -253 B (removed) 🏆
dist/system/index.production.js 0 B -183 B (removed) 🏆
dist/system/macro.development.js 0 B -780 B (removed) 🏆
dist/system/macro.production.js 0 B -556 B (removed) 🏆
dist/system/macro/vite.development.js 0 B -951 B (removed) 🏆
dist/system/macro/vite.production.js 0 B -660 B (removed) 🏆
dist/system/react.development.js 0 B -872 B (removed) 🏆
dist/system/react.production.js 0 B -473 B (removed) 🏆
dist/system/react/utils.development.js 0 B -357 B (removed) 🏆
dist/system/react/utils.production.js 0 B -237 B (removed) 🏆
dist/system/utils.development.js 0 B -259 B (removed) 🏆
dist/system/utils.production.js 0 B -187 B (removed) 🏆
dist/system/vanilla.development.js 0 B -2.58 kB (removed) 🏆
dist/system/vanilla.production.js 0 B -1.52 kB (removed) 🏆
dist/system/vanilla/utils.development.js 0 B -3.38 kB (removed) 🏆
dist/system/vanilla/utils.production.js 0 B -2.22 kB (removed) 🏆
dist/umd/index.development.js 0 B -382 B (removed) 🏆
dist/umd/index.production.js 0 B -330 B (removed) 🏆
dist/umd/macro.development.js 0 B -1.03 kB (removed) 🏆
dist/umd/macro.production.js 0 B -721 B (removed) 🏆
dist/umd/macro/vite.development.js 0 B -1.23 kB (removed) 🏆
dist/umd/macro/vite.production.js 0 B -879 B (removed) 🏆
dist/umd/react.development.js 0 B -814 B (removed) 🏆
dist/umd/react.production.js 0 B -526 B (removed) 🏆
dist/umd/react/utils.development.js 0 B -433 B (removed) 🏆
dist/umd/react/utils.production.js 0 B -314 B (removed) 🏆
dist/umd/utils.development.js 0 B -398 B (removed) 🏆
dist/umd/utils.production.js 0 B -344 B (removed) 🏆
dist/umd/vanilla.development.js 0 B -2.76 kB (removed) 🏆
dist/umd/vanilla.production.js 0 B -1.64 kB (removed) 🏆
dist/umd/vanilla/utils.development.js 0 B -7.14 kB (removed) 🏆
dist/umd/vanilla/utils.production.js 0 B -4.92 kB (removed) 🏆
dist/vanilla.js 2.35 kB -280 B (-11%) 👏
dist/vanilla/utils.js 2.4 kB -4.56 kB (-66%) 🏆
ℹ️ View Unchanged
Filename Size
dist/index.js 243 B
dist/react/utils.js 277 B
dist/utils.js 247 B

compressed-size-action

* [v2] breaking: do not throw promises

* use use

* fix CI hopefully

* fix CI hopefully 2

* fix CI hopefully 3

* fix CI hopefully 4

* fix CI hopefully 5

* any type for simplicity
* [v2] breaking: do not copy initial objects

* fix deepClone

* refactor

* ah we need it

* deep clone

* minor fix
* TS minimal requirement v4.5

* wip: test old ts

* remove downlevel-dts

* simplify test

* simplify test 2

* simplify test 3

* wip: useMaybePromise

* wip: useMaybePromise 2

* wip: useMaybePromise 3

* rename back
* [v2] breaking: require react 18 and drop use-sync-external-store

* drop tests pre react 18

* wip: cannot use react 17 for prd test

* drop production test which is impossible

* esm?

* fix regex

* fix sed
* remove depreacated useProxy macro

* revert plugin-transform

* remove two more babel packages

* revert babel core

* remove proxyWithComputed

* remove addComputed

* remove devtools deprecated option
* [v2] breaking: drop UMD/SystemJS builds and simplify babel config

* format
@dai-shi
Copy link
Member Author

dai-shi commented Mar 23, 2024

@dai-shi dai-shi mentioned this pull request Apr 1, 2024
@dai-shi
Copy link
Member Author

dai-shi commented Apr 29, 2024

* Address spurious consistency check re-renders by using useLayoutEffect inside useSnapshot instead of useEffect

* Move regression tests for useSnapshot perf improvement to optimization test file

* Update tests/optimization.test.tsx

---------

Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
@dai-shi dai-shi marked this pull request as ready for review May 4, 2024 00:22
@dai-shi
Copy link
Member Author

dai-shi commented May 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants