Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bind to default framebuffer only when copying from main canvas #10486

Merged
merged 1 commit into from
Apr 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { Rectangle } from '../../../../maths/shapes/Rectangle';
import { warn } from '../../../../utils/logging/warn';
import { CanvasSource } from '../../shared/texture/sources/CanvasSource';
import { CLEAR } from '../const';
import { GlRenderTarget } from '../GlRenderTarget';

Expand Down Expand Up @@ -162,8 +161,8 @@ export class GlRenderTargetAdaptor implements RenderTargetAdaptor<GlRenderTarget

const glRenderTarget = new GlRenderTarget();

// we are rendering to a canvas..
if (CanvasSource.test(renderTarget.colorTexture.resource))
// we are rendering to the main canvas..
if (renderTarget.colorTexture.resource === renderer.gl.canvas)
{
glRenderTarget.framebuffer = null;

Expand Down