Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: bind to default framebuffer only when copying from main canvas #10486

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Fix: bind to default framebuffer only when copying from main canvas #10486

merged 1 commit into from
Apr 30, 2024

Commits on Apr 29, 2024

  1. Bind to null framebuffer only when copy from main canvas 

    The render target system's copyToTexture assumes that if the source render surface is a canvas, then it must be the main framebuffer. But this is false if someone is trying to copy from a secondary or offscreen canvas.

For a bug repro, see this JSFiddle
https://jsfiddle.net/ShukantPal/vwrh51qs/27/

I've verified locally that this fix causes the gradient to paint correctly
    @ShukantPal
    ShukantPal committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    644fdf7 View commit details
    Browse the repository at this point in the history