Format codebase with laravel/pint (Followup to #4921) #4922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jippi
force-pushed
the
jippi/format-with-pint
branch
from
f740d3a
to
9812f5f
Compare
jippi
force-pushed
the
jippi/format-with-pint
branch
from
9812f5f
to
cd5325d
Compare
|
As discussed on Discord, this PR is way too big and I have a plan to incorporate proper code style formatting that is in the works! |
|
This is "proper code style formatting" though? :) using Laravels' own code style - there are no changes in the PR beyond formatting (intentionally so) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #4921 with laravel/pint formatting applied.
Having a strong, consistent, and automated formatter is important for consistency and ease of contribution.
It makes code more readable, and thus easier to maintain and contribute to.
This matters as code is read much more frequently than it's written, and it significantly lowers the cognitive load of navigating the code base.
I picked
pintbecause this is a Laravel project, so using the Laravel formatter seemed optimal, but I don't care too deeply about which one is used at the end of the day.Any ongoing PRs should have minimal interruption / merge conflicts if they apply
pintformatting in their own commit and then pull instagingon top of it.NOTE If this approach is fine, I will rebase before merging, as it right now will keep causing conflicts