Code styles are inconsistent

[dariusj18]

The projects has an .editorconfig file, however there are still commits like this 7355e94 where the code changes are confusing because the spaces were changed to tabs.

Since this is a Laravel project I would advise following PSR-12.

CircleCI or GitHub actions could be used to automate testing.

Here's an example I found with a quick search of a project implementing Github actions for php code sniffing. https://github.com/typo3-trainer-network/books/pull/38/files

[shleeable]

It's easy to add a github action to check against these standards.

I've just done a scan and the PR to change up to PSR-1, then PSR-12 is going to effect every file ;)
So @dansup really needs to be keen to run these code standard changes, because his code standard is obviously his preference.

[dansup]

Someone else contributed the .editorconfig file, we did use StyleCI at one point but it wasn't configured properly so I removed it.

I plan to tackle this in v0.12 (the big refactor), will keep this open until I fix!

[svenluijten]

@dansup what's the status of this? As the project has gotten more contributors, I think it's smart to tackle this now before it gets too unwieldy and it can't be changed at all (if it hasn't yet). Enabling StyleCI should be pretty minor and only affect new code that's contributed to the project, so you won't have a massive PR like #2064.

[jippi]

#4921 +#4922 was intended to fix this :)