Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix apache configuration documentation #16599

Open
wants to merge 1 commit into
base: 11.2
Choose a base branch
from
Open

fix apache configuration documentation #16599

wants to merge 1 commit into from

Conversation

dbu
Copy link

@dbu dbu commented Feb 12, 2024

Please make sure your PR complies with all of the following points:

  • Read and accept our contributing guidelines before you submit a PR.
  • Features need to be proper documented in doc/
  • Bugfixes need a short guide how to reproduce them -> target branch is the oldest supported maintenance branch, e.g. 11.1 (see Readme.md for the list of supported versions)
  • Meet all coding standards (see PhpStan actions)

Changes in this pull request

I tried the setup instructions but did not get static files to be served. Not sure if the original configuration would be the correct one for some versions of Apache (its been quite a while since i had to use it), but with my 2.4.57, the REQUEST_FILENAME is only the path and we need to prepend the DOCUMENT_ROOT

Copy link

Review Checklist

  • Target branch (11.1 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@dbu dbu mentioned this pull request Feb 12, 2024
4 tasks
@robertSt7
Copy link
Contributor

@dbu Since this is a bugfix, could you please rebase the PR to 11.1? Thanks

@kingjia90 kingjia90 changed the base branch from 11.x to 11.1 February 13, 2024 07:46
we need to check for the file in the document root. `%{REQUEST_FILENAME}` does not include the document root
@brusch
Copy link
Member

brusch commented Feb 13, 2024

@dbu were you using the config in the context of a .htaccess or directly in the vhost?

@dbu
Copy link
Author

dbu commented Feb 13, 2024

uh, that might explain it 🙈

i use it in the vhost configuration. i have not done much apache in the last decade, but back in the days .htaccess was considered the hacky solution. might well be that in .htaccess it would work without the change. if it still works with the change too, it could make sense to keep it for others who also configure the vhost directly.

@brusch
Copy link
Member

brusch commented Feb 13, 2024

@dbu Yeah, I guess that's the reason then 😊
I'm not (entirely) sure whether your change also works in the context of .htaccess and I currently don't have the possibility to test it. Maybe someone else could help here? 😊

@kingjia90 kingjia90 deleted the branch pimcore:11.2 March 12, 2024 15:13
@kingjia90 kingjia90 closed this Mar 12, 2024
@kingjia90 kingjia90 reopened this Mar 13, 2024
Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kingjia90 kingjia90 changed the base branch from 11.1 to 11.2 March 13, 2024 07:41
@fashxp
Copy link
Member

fashxp commented Mar 29, 2024

anyone in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants