Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix apache configuration documentation #16520

Closed
wants to merge 1 commit into from
Closed

fix apache configuration documentation #16520

wants to merge 1 commit into from

Conversation

dbu
Copy link

@dbu dbu commented Jan 29, 2024

Please make sure your PR complies with all of the following points:

  • Read and accept our contributing guidelines before you submit a PR.
  • Features need to be proper documented in doc/
  • Bugfixes need a short guide how to reproduce them -> target branch is the oldest supported maintenance branch, e.g. 11.1 (see Readme.md for the list of supported versions)
  • Meet all coding standards (see PhpStan actions)

Changes in this pull request

I tried the setup instructions but did not get static files to be served. Not sure if the original configuration would be the correct one for some versions of Apache (its been quite a while since i had to use it), but with my 2.4.57, the REQUEST_FILENAME is only the path and we need to prepend the DOCUMENT_ROOT

@CLAassistant
Copy link

CLAassistant commented Jan 29, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Review Checklist

  • Target branch (11.0 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@fashxp fashxp changed the base branch from 10.6 to 11.1 January 29, 2024 20:58
@fashxp fashxp added the Task label Jan 29, 2024
@fashxp
Copy link
Member

fashxp commented Jan 29, 2024

Thx very much.
10.6 branch is EOL, we need to merge into 11.1. Could you please try to resolve the conflicts.

Thanks again...

@brusch
Copy link
Member

brusch commented Feb 12, 2024

@dbu 🏓😉

@dbu
Copy link
Author

dbu commented Feb 12, 2024

i just created a new MR #16599 , that was the simplest for the tiny change.

@dbu dbu closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants