Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3 Support #16589

Merged
merged 3 commits into from
Feb 12, 2024
Merged

PHP 8.3 Support #16589

merged 3 commits into from
Feb 12, 2024

Conversation

brusch
Copy link
Member

@brusch brusch commented Feb 12, 2024

Resolves #16350

@brusch brusch added this to the 11.2.0 milestone Feb 12, 2024
Copy link

Review Checklist

  • Target branch (11.1 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@jdreesen
Copy link
Contributor

Duplicate of #16564?

Copy link

sonarcloud bot commented Feb 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@brusch
Copy link
Member Author

brusch commented Feb 12, 2024

@jdreesen in a way yes, but with less jobs defined by the matrix - so a bit optimized 😉

@limenet
Copy link
Contributor

limenet commented Apr 25, 2024

@brusch now that this MR has been merged and Pimcore supports PHP 8.3, can you please create releases for the bundles containing the MRs for PHP 8.3 as well?

Right now using e.g. the pimcore/personalization-bundle with PHP 8.3 is not possible since pimcore/personalization-bundle#66 is merged yet not part of a tagged version. However, most bundles are affected by this; either the MR is still open (see also pimcore/customer-data-framework#529 (comment)) or no new tag has been created so far.

Thank you!

@blankse
Copy link
Contributor

blankse commented Apr 25, 2024

@limenet There are problems with the imagick php module in PHP 8.3.
See: pimcore/docker#148

So I think you should stay on PHP 8.2 and Pimcore have no hurray to support it everywhere.

@fashxp
Copy link
Member

fashxp commented Apr 25, 2024

@limenet There are problems with the imagick php module in PHP 8.3. See: pimcore/docker#148

So I think you should stay on PHP 8.2 and Pimcore have no hurray to support it everywhere.

that's also the reason why that topic hasn't top prio for us right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.3 Support
5 participants