PHP 8.3 Support #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @blankse, is this really necessary? Just wondering because this bundle provides aliases for classes which were moved in Pimcore 11 compared to Pimcore 10. I would say when we are adding PHP 8.3 support somewhere we should drop Pimcore 10 and this bundle from dependency. Or did I miss something? :) |
|
@lukmzig It is necessary for data-hub. See pimcore/data-hub#840 |
|
@blankse I double checked with my colleagues, we can merge this and in the next major release we will drop Pimcore 10 support from data hub. Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See pimcore/pimcore#16589