Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fix for selecting SELECT elements #2338

Merged
merged 2 commits into from Dec 10, 2016

Conversation

ramiroaraujo
Copy link
Contributor

@ramiroaraujo ramiroaraujo commented Nov 9, 2016

This issue has been reported and verified in #2257 and #2287, and was introduced with Chrome v53.
It's been noted in #2257 that calling focus() on the select element could do the trick, and indeed it does. It doesn't expand the select as it used to be, but at least it's focused.

The fix treats the select elements the same as input elements, and simply focus on them.
I've also updated the test to verify the focus on the element.

I've been using this fix for a few days now, since I couldn't go by without hitting selects any more. Hope it helps!

@gdh1995
Copy link
Contributor

gdh1995 commented Nov 13, 2016

+1

Some ideas:

  • I think we may also focus <embed>s and <object>s.
  • It seems that clickEl.type not in ["button", "submit"] is not needed, because else if DomUtils.isSelectable clickEl in Line 390 has checked the same thing.

@ramiroaraujo
Copy link
Contributor Author

@gdh1995 I would prefer to keep this PR as simple as possible, "focusing" solely on the <select> issue

@smblott-github smblott-github merged commit 6e782d8 into philc:master Dec 10, 2016
smblott-github added a commit that referenced this pull request Dec 10, 2016
@smblott-github
Copy link
Collaborator

That's really nice, @ramiroaraujo, thanks.

(And sorry for the delay.)

@AndrewSouthpaw
Copy link

Any chance we could get a version bump on the Chrome extensions store, so we can all more easily benefit from this partial fix? :)

@vmindru
Copy link

vmindru commented Jan 2, 2017

+1 need a version bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants