Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimium cannot "click" select elements #2257

Closed
daemedeor opened this issue Sep 19, 2016 · 17 comments
Closed

Vimium cannot "click" select elements #2257

daemedeor opened this issue Sep 19, 2016 · 17 comments
Labels

Comments

@daemedeor
Copy link

Previously when I used vim on Chrome 51 or thereabouts the dropdown used to open when I hit f and then the associated tag that vimium tagged the field with. Now vimium still tags the field but it doesn't seem to open the select boxes. I tried it on several pages by adding my own select boxes but I'm not quite sure why its not working. Any workaround?

@smblott-github
Copy link
Collaborator

@daemedeor... Could you provide an example page?

(This works on Facebook, for me.)

@daemedeor
Copy link
Author

Here: http://store.steampowered.com/agecheck/app/234140/?snr=1_239_4__122, if you have steam. also note: I'm on Chrome 53, Seirra, macOS.

screen shot 2016-09-19 at 7 10 30 am

@smblott-github
Copy link
Collaborator

This sounds more likely to be a change in how the page is implemented. All Vimium does is "click" the element, and that hasn't changed. To get the drop down you have to hover (which Vimium cannot currently do).

The Vimium click behaviour seems to be exactly the same as a mouse click.

@daemedeor daemedeor reopened this Sep 19, 2016
@romgrk
Copy link

romgrk commented Sep 20, 2016

Hello,
I have been seeing warnings pop up in the console (when clicking through vimium), saying that some non-standard behaviors would be removed from Chrome sometime during September, so I'm guessing that this is it. I'm using version 54 and those warnings have disappeared, along with the ability to click through vimium.

@romgrk
Copy link

romgrk commented Sep 20, 2016

After a bit of investigation, it seems that it is indeed unstandard to be able to open a select element through javascript. Given that Chrome/ium is lately pushing to more standardization, I think it is unlikely they will go back to the old behavior. I would recommend at least triggering a 'focus' event on such elements, so the user can trigger it with space subsequently.

@smblott-github
Copy link
Collaborator

@romgrk... If you're referring to the following console message regarding keyIdentifier, then we already have code in place to cover its removal:

snapshot

Regarding Chrome 54... I tried it, and didn't have any issues with link hints. Please post a link and a description of the steps to reproduce.

@romgrk
Copy link

romgrk commented Sep 20, 2016

Oh, well,

  1. Find any select element (eg the selects elements from the steam page above)
  2. f + xx
  3. No reaction; the vimium flash shows up but then nothing more.

And no, it was a similar warning but it was triggered when "clicking" a select element. Unfortunately I can't give you any data because it doesn't show up anymore.

@smblott-github smblott-github changed the title Bug: Dropdowns no longer open Vimium cannot "click" select elements Sep 20, 2016
@smblott-github
Copy link
Collaborator

smblott-github commented Sep 20, 2016

OK. I see now. It's the same in Chrome 53.

Edit... There's a better test page here.

@gdh1995
Copy link
Contributor

gdh1995 commented Sep 24, 2016

Before Chrome ~~52/~~53, <select> element is "opened" on a mousedown event, but the Chrome developers changed this behavior into:

  • only those default browser actions triggered by click events are allowed to be called by untrusted events (which are usually created by JavaScript code)
  • so clicking <a download=""> will trigger the File Save Dialog
  • while we have no methods to "open" a <select> popup menu.

Some ones have pulled a request to add .open() and .close() methods to <select> elements, but it's not accepted yet.

You may see https://www.chromestatus.com/features/5718803933560832 for more explanations.

@IamGianluca
Copy link

IamGianluca commented Oct 4, 2016

This happens also when browsing the python documentation. If you try to move to the same page for a different version of python using the drop down menu on the top left of the page.

Browser: Google Chrome Version 53.0.2785.143 (64-bit)
OS: GNU/Linux Ubuntu 16.04 LTS
Vimium: 1.57

Interestingly the same doesn't happen in GitHub.

@daemedeor
Copy link
Author

@IamGianluca It's important to note that some "drop down boxes" are not really drop down boxes. Like the upper part where "Watch" is, even though the behavior is similar to a drop down, its actually a link. Probably so they could have an easier time to stylize it. Overriding the default select boxes are a world of pain

@nilskaspersson
Copy link

Running focus() on the <select> when it's clicked through Vimium is probably the best solution to this issue.

@jlevitt
Copy link

jlevitt commented Jan 26, 2017

I've also hit this issue, used to work, now no selects work with vimium. I see #2338 may fix this issue? Is there a way to get the update? (I don't see a new release).

@smblott-github
Copy link
Collaborator

I think we'll push the new stuff in the coming week or two; just need to check with @philc.

@AndrewSouthpaw
Copy link

Any chance we can get a version bump? Not having access to dropdowns reduces the usefulness of this (otherwise excellent) extension.

@philc
Copy link
Owner

philc commented Mar 8, 2017 via email

@smblott-github
Copy link
Collaborator

smblott-github commented Mar 8, 2017

let's release

Will do.

Edit... Done. 1.58 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants