chore: version permissions #6068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsfletch
force-pushed
the
fix/versions-permissions
branch
2 times, most recently
from
87f115f
to
266021f
Compare
jacobsfletch
force-pushed
the
fix/versions-permissions
branch
from
24deadb
to
7111834
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes payloadcms/payload-3.0-demo#146. Collections without version read access would still render their versions tab, ultimately leading the user to a 403. For the record, this is in fact the current behavior of 2.0. This is mostly a quality of life improvement. Permissions are now thread to each tab's condition function so that it can determine its own logic. Versions were also previously being requested (403ing) even though we already know whether they have read access to versions. Now, no versions are fetched unless needed.