fix(ui): conditionally fetches versions based on read access

payloadcms · Apr 26, 2024 · 87f115f · 87f115f
1 parent 5c816d9
commit 87f115f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/packages/ui/src/providers/DocumentInfo/index.tsx b/packages/ui/src/providers/DocumentInfo/index.tsx
@@ -82,11 +82,11 @@ export const DocumentInfoProvider: React.FC<
   }
 
   const isEditing = Boolean(id)
+  const shouldFetchVersions = Boolean(versionsConfig && docPermissions?.readVersions?.permission)
 
   const getVersions = useCallback(async () => {
     let versionFetchURL
     let publishedFetchURL
-    const shouldFetchVersions = Boolean(versionsConfig)
     let unpublishedVersionJSON = null
     let versionJSON = null
     let shouldFetch = true
@@ -209,7 +209,7 @@ export const DocumentInfoProvider: React.FC<
       setVersions(versionJSON)
       setUnpublishedVersions(unpublishedVersionJSON)
     }
-  }, [i18n, globalSlug, collectionSlug, id, baseURL, locale, versionsConfig])
+  }, [i18n, globalSlug, collectionSlug, id, baseURL, locale, versionsConfig, shouldFetchVersions])
 
   const getDocPermissions = React.useCallback(async () => {
     let docAccessURL: string
@@ -364,8 +364,10 @@ export const DocumentInfoProvider: React.FC<
   ])
 
   useEffect(() => {
-    void getVersions()
-  }, [getVersions])
+    if (shouldFetchVersions) {
+      void getVersions()
+    }
+  }, [getVersions, shouldFetchVersions])
 
   useEffect(() => {
     setDocumentTitle(

diff --git a/test/_community/collections/Posts/index.ts b/test/_community/collections/Posts/index.ts
@@ -9,6 +9,9 @@ export const PostsCollection: CollectionConfig = {
   admin: {
     useAsTitle: 'text',
   },
+  access: {
+    readVersions: () => false,
+  },
   fields: [
     {
       name: 'text',