Prepare Release v1.30.0 #1642

cmslewis · 2017-09-29T22:53:13Z

📖 Latest docs: blueprintjs.com/docs

`@blueprintjs/core 1.30.0`

🔄 Changed

[Table/Core] Move some table utils into core #1604 Moved the following Utils functions from packages/table into packages/core:
- arraysEqual
- deepCompareKeys
- getDeepUnequalKeyValues
- getShallowUnequalKeyValues
- shallowCompareKeys

🐛 Bug fixes

[EditableText] Fix multiline height for long strings with no spaces #1608 EditableText now elegantly handles long strings with no spaces. (🎩 @luyao-wang)
[Input group] More precise selector for spinners in input groups #1616 InputGroup now properly styles pt-spinners contained in child buttons.

`@blueprintjs/table 1.27.0`

🔄 Changed

[Table] Move useInteractionBar prop to <Table>, deprecate the <ColumnHeaderCell> one #1627 Table now supports the useInteractionBar prop.
- ColumnHeaderCell's useInteractionBar prop is now deprecated.
- We made this change for two reasons:
  - From a design perspective, the interaction bar should be enabled for all cells at once or for none at all. Thus, it makes sense to provide the flag to the top-level Table component.
  - This change enables a fix for a bug where the column header wouldn't resize properly when useInteractionBar was toggled on and off.
[Table/Core] Move some table utils into core #1604 Moved the following Utils functions from packages/table into packages/core:
- arraysEqual
- deepCompareKeys
- getDeepUnequalKeyValues
- getShallowUnequalKeyValues
- shallowCompareKeys
[Table] Introduce TableBodyCells component to avoid unnecessary cell renders #1596 [Table] Don't render LEFT and TOP_LEFT quadrants if they're not needed #1621 Table now renders and updates fewer DOM elements under the hood in certain cases, leading to slightly faster rendering performance.

🐛 Bug fixes

[Table] Don't render LEFT and TOP_LEFT quadrants if they're not needed #1621 Table now aligns the left selection/focused-cell border properly when row headers are hidden:
[Table] Fix missing selection border on left edge of grid #1622 Table now shows a left border on selected regions that include cells in the first column when row headers are visible.
[Table] TruncatedFormat popover improvements and performance tuning for dev preview #1624 TruncatedFormat now does fewer DOM reads when the content popover is closed, leading to slightly improved rendering performance.

`@blueprintjs/labs 0.11.0`

💎 New features

[Labs/Popover2] Ease Popover2 migration with prop shims #1581 Popover2 now offers shims for renamed props to ease migration from Popover (🎩 @brieb)

blueprint-bot · 2017-09-29T23:00:56Z

Fix package versions

Preview: documentation | table | github pages
Coverage: core | datetime

cmslewis · 2017-09-29T23:45:21Z

package.json

@@ -1,6 +1,6 @@
 {
  "name": "blueprint-monorepo",
-  "version": "1.28.0",


Oops, we didn't bump this for 1.29.0.

cmslewis · 2017-09-29T23:45:50Z

packages/table/package.json

@@ -20,7 +20,7 @@
    "watch": "onchange 'src/**' 'preview/*.ts*' -- npm-run-all build:gulp build:preview"
  },
  "dependencies": {
-    "@blueprintjs/core": "^1.25.0",
+    "@blueprintjs/core": "^1.30.0",


Bumping because of the utils that moved from table to core.

is this the correct minimum version?

Yup, as Chris mentioned, some utils moved from table to core

well sure but didn't that move actually happen last release? 1.29.0?

no big deal though.

nvm, I see release notes. my bad.

blueprint-bot · 2017-09-29T23:53:20Z

Undo version bumps on datetime and docs

Preview: documentation | table | github pages
Coverage: core | datetime

adidahiya

site-docs.js diff is surprising -- 40k lines removed?
we might as well bump labs' dependency on core as well so that we can start using the compare utils there

adidahiya · 2017-09-30T16:08:09Z

also please remove tslint changes from the release notes.

cmslewis · 2017-10-01T06:34:22Z

@adidahiya @giladgray a lot of the removals seem to be related to moment-timezone. I'm seeing an error related to it when the prepRelease.sh script runs:

[23:24:17] Finished 'bundle-core' after 1.5 s
[23:24:17] [webpack] Time: 1580ms
             Asset    Size  Chunks             Chunk Names
    labs.bundle.js  279 kB       0  [emitted]  labs
labs.bundle.js.map  331 kB       0  [emitted]  labs

ERROR in ./packages/labs/~/moment-timezone/data/packed/latest.json
Module parse failed: /Users/clewis/Developer/blueprint-external/packages/labs/node_modules/moment-timezone/data/packed/latest.json Unexpected token (2:10)
You may need an appropriate loader to handle this file type.
SyntaxError: Unexpected token (2:10)
  at Parser.pp$4.raise (/Users/clewis/Developer/blueprint-external/node_modules/webpack/node_modules/acorn/dist/acorn.js:2221:15)
  at Parser.pp.unexpected (/Users/clewis/Developer/blueprint-external/node_modules/webpack/node_modules/acorn/dist/acorn.js:603:10)
  at Parser.pp.semicolon (/Users/clewis/Developer/blueprint-external/node_modules/webpack/node_modules/acorn/dist/acorn.js:581:61)
  at Parser.pp$1.parseExpressionStatement (/Users/clewis/Developer/blueprint-external/node_modules/webpack/node_modules/acorn/dist/acorn.js:966:10)
  at Parser.pp$1.parseStatement (/Users/clewis/Developer/blueprint-external/node_modules/webpack/node_modules/acorn/dist/acorn.js:730:24)
  at Parser.pp$1.parseBlock (/Users/clewis/Developer/blueprint-external/node_modules/webpack/node_modules/acorn/dist/acorn.js:981:25)
  at Parser.pp$1.parseStatement (/Users/clewis/Developer/blueprint-external/node_modules/webpack/node_modules/acorn/dist/acorn.js:709:33)
  at Parser.pp$1.parseTopLevel (/Users/clewis/Developer/blueprint-external/node_modules/webpack/node_modules/acorn/dist/acorn.js:638:25)
  at Parser.parse (/Users/clewis/Developer/blueprint-external/node_modules/webpack/node_modules/acorn/dist/acorn.js:516:17)
  at Object.parse (/Users/clewis/Developer/blueprint-external/node_modules/webpack/node_modules/acorn/dist/acorn.js:3098:39)
  at Parser.parse (/Users/clewis/Developer/blueprint-external/node_modules/webpack/lib/Parser.js:902:15)
  at NormalModule.<anonymous> (/Users/clewis/Developer/blueprint-external/node_modules/webpack/lib/NormalModule.js:104:16)
  at NormalModule.onModuleBuild (/Users/clewis/Developer/blueprint-external/node_modules/webpack-core/lib/NormalModuleMixin.js:310:10)
  at nextLoader (/Users/clewis/Developer/blueprint-external/node_modules/webpack-core/lib/NormalModuleMixin.js:275:25)
  at /Users/clewis/Developer/blueprint-external/node_modules/webpack-core/lib/NormalModuleMixin.js:259:5
  at Storage.finished (/Users/clewis/Developer/blueprint-external/node_modules/webpack/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:38:16)
  at /Users/clewis/Developer/blueprint-external/node_modules/graceful-fs/graceful-fs.js:78:16
  at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:504:3)

 @ ./packages/labs/~/moment-timezone/index.js 2:15-51
[23:24:17] Finished 'bundle-labs' after 1.58 s

I'm also seeing the following later in the build:

[23:24:36] [webpack] Time: 16627ms
           Asset     Size  Chunks             Chunk Names
    site-docs.js  5.39 MB       0  [emitted]  site-docs
site-docs.js.map  6.63 MB       0  [emitted]  site-docs

ERROR in ./packages/labs/examples/omniboxExample.tsx
(17,5): error TS6133: 'IToastProps' is declared but never used.

ERROR in ./packages/labs/src/components/timezone-picker/timezoneMetadata.ts
(30,26): error TS2339: Property 'population' does not exist on type 'MomentZone'.

ERROR in /Users/clewis/Developer/blueprint-external/packages/labs/node_modules/popper.js/index.d.ts
(9,15): error TS2300: Duplicate identifier 'Position'.

ERROR in /Users/clewis/Developer/blueprint-external/packages/labs/node_modules/popper.js/index.d.ts
(11,15): error TS2300: Duplicate identifier 'Placement'.

ERROR in /Users/clewis/Developer/blueprint-external/packages/labs/node_modules/popper.js/index.d.ts
(27,15): error TS2300: Duplicate identifier 'Boundary'.

ERROR in /Users/clewis/Developer/blueprint-external/packages/labs/node_modules/popper.js/index.d.ts
(29,15): error TS2300: Duplicate identifier 'ModifierFn'.

ERROR in /Users/clewis/Developer/blueprint-external/packages/labs/node_modules/popper.js/index.d.ts
(62,5): error TS2374: Duplicate string index signature.

ERROR in /Users/clewis/Developer/blueprint-external/packages/labs/node_modules/popper.js/index.d.ts
(106,24): error TS2300: Duplicate identifier 'Popper'.

ERROR in /Users/clewis/Developer/blueprint-external/packages/site-docs/node_modules/@blueprintjs/labs/node_modules/popper.js/index.d.ts
(9,15): error TS2300: Duplicate identifier 'Position'.

ERROR in /Users/clewis/Developer/blueprint-external/packages/site-docs/node_modules/@blueprintjs/labs/node_modules/popper.js/index.d.ts
(11,15): error TS2300: Duplicate identifier 'Placement'.

ERROR in /Users/clewis/Developer/blueprint-external/packages/site-docs/node_modules/@blueprintjs/labs/node_modules/popper.js/index.d.ts
(27,15): error TS2300: Duplicate identifier 'Boundary'.

ERROR in /Users/clewis/Developer/blueprint-external/packages/site-docs/node_modules/@blueprintjs/labs/node_modules/popper.js/index.d.ts
(29,15): error TS2300: Duplicate identifier 'ModifierFn'.

ERROR in /Users/clewis/Developer/blueprint-external/packages/site-docs/node_modules/@blueprintjs/labs/node_modules/popper.js/index.d.ts
(106,24): error TS2300: Duplicate identifier 'Popper'.
[23:24:36] Finished 'webpack-docs' after 17 s
[23:24:36] Finished 'build' after 34 s

Could any of these errors be causing undesired deletions from the site-docs bundle?

blueprint-bot · 2017-10-01T06:41:02Z

Bump labs package dependency on core

Preview: documentation | table | github pages
Coverage: core | datetime

cmslewis · 2017-10-02T19:03:03Z

@giladgray is taking a look at this release today to see if things look good.

…ackage

giladgray · 2017-10-02T19:12:07Z

ok pushed some build fixes. we should still see the timezoneMetadata and popper.js errors noted at the end of #1642 (comment) (until #1527 is resolved), but the labs.bundle.js error should be fixed.

giladgray · 2017-10-02T19:18:15Z

@adidahiya @cmslewis pretty sure the -40k lines on docs.js is entirely due to prettier formatting things to require fewer lines. for instance, the massive docs.json blob now sits on exactly one line, instead of thirty-two thousand.

blueprint-bot · 2017-10-02T19:19:26Z

rebuild site

Preview: documentation | table | github pages
Coverage: core | datetime

giladgray · 2017-10-02T19:23:00Z

gulp/util/webpack-config.js

+    module: {
+        loaders: [
+            // always provide JSON loader to support importing data files (see moment-timezone)
+            { loader: "json-loader", test: /\.json$/ },


this resolve the latest.json issue from labs.bundle.js

adidahiya · 2017-10-02T20:13:11Z

@giladgray @cmslewis prettier shouldn't be running on built files; did you run gulp lint-fix in this PR?

cmslewis · 2017-10-02T20:28:53Z

@adidahiya no, I didn't.

DrewDennison · 2017-10-03T17:05:32Z

@cmslewis did this make it to NPM yet?

adidahiya · 2017-10-03T17:08:55Z

The release build failed; we're looking into it now.

cmslewis added 2 commits September 29, 2017 15:23

Prepare Release v1.30.0

ad91cb6

Fix package versions

c6e5f66

cmslewis requested review from llorca, giladgray, adidahiya, tgreenwatts, themadcreator and gscshoyru September 29, 2017 23:03

llorca approved these changes Sep 29, 2017

View reviewed changes

Undo version bumps on datetime and docs

4b05f84

cmslewis commented Sep 29, 2017

View reviewed changes

adidahiya reviewed Sep 30, 2017

View reviewed changes

Bump labs package dependency on core

e16fd90

cmslewis mentioned this pull request Oct 2, 2017

[Table] Utils.shallowCompareKeys is not a function #1639

Closed

Gilad Gray added 3 commits October 2, 2017 12:07

remove unused import

296f588

build fixes: add json-loader to all bundle tasks, localResolve labs p…

ff8f9ea

…ackage

rebuild site

4464607

giladgray reviewed Oct 2, 2017

View reviewed changes

giladgray approved these changes Oct 2, 2017

View reviewed changes

cmslewis merged commit 48ab7b7 into master Oct 2, 2017

cmslewis deleted the release/1.30.0 branch October 2, 2017 20:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare Release v1.30.0 #1642

Prepare Release v1.30.0 #1642

cmslewis commented Sep 29, 2017 •

edited

blueprint-bot commented Sep 29, 2017

cmslewis Sep 29, 2017

cmslewis Sep 29, 2017

giladgray Oct 2, 2017

llorca Oct 2, 2017

cmslewis Oct 2, 2017

giladgray Oct 2, 2017 •

edited

giladgray Oct 2, 2017

blueprint-bot commented Sep 29, 2017

adidahiya left a comment

adidahiya commented Sep 30, 2017

cmslewis commented Oct 1, 2017

blueprint-bot commented Oct 1, 2017

cmslewis commented Oct 2, 2017

giladgray commented Oct 2, 2017

giladgray commented Oct 2, 2017 •

edited

blueprint-bot commented Oct 2, 2017

giladgray Oct 2, 2017

adidahiya commented Oct 2, 2017

cmslewis commented Oct 2, 2017

DrewDennison commented Oct 3, 2017

adidahiya commented Oct 3, 2017

Prepare Release v1.30.0 #1642

Prepare Release v1.30.0 #1642

Conversation

cmslewis commented Sep 29, 2017 • edited

@blueprintjs/core 1.30.0

🔄 Changed

🐛 Bug fixes

@blueprintjs/table 1.27.0

🔄 Changed

🐛 Bug fixes

@blueprintjs/labs 0.11.0

💎 New features

blueprint-bot commented Sep 29, 2017

Fix package versions

cmslewis Sep 29, 2017

Choose a reason for hiding this comment

cmslewis Sep 29, 2017

Choose a reason for hiding this comment

giladgray Oct 2, 2017

Choose a reason for hiding this comment

llorca Oct 2, 2017

Choose a reason for hiding this comment

cmslewis Oct 2, 2017

Choose a reason for hiding this comment

giladgray Oct 2, 2017 • edited

Choose a reason for hiding this comment

giladgray Oct 2, 2017

Choose a reason for hiding this comment

blueprint-bot commented Sep 29, 2017

Undo version bumps on datetime and docs

adidahiya left a comment

Choose a reason for hiding this comment

adidahiya commented Sep 30, 2017

cmslewis commented Oct 1, 2017

blueprint-bot commented Oct 1, 2017

Bump labs package dependency on core

cmslewis commented Oct 2, 2017

giladgray commented Oct 2, 2017

giladgray commented Oct 2, 2017 • edited

blueprint-bot commented Oct 2, 2017

rebuild site

giladgray Oct 2, 2017

Choose a reason for hiding this comment

adidahiya commented Oct 2, 2017

cmslewis commented Oct 2, 2017

DrewDennison commented Oct 3, 2017

adidahiya commented Oct 3, 2017

cmslewis commented Sep 29, 2017 •

edited

`@blueprintjs/core 1.30.0`

`@blueprintjs/table 1.27.0`

`@blueprintjs/labs 0.11.0`

giladgray Oct 2, 2017 •

edited

giladgray commented Oct 2, 2017 •

edited