Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Utils.shallowCompareKeys is not a function #1639

Closed
locnguyen opened this issue Sep 29, 2017 · 8 comments
Closed

[Table] Utils.shallowCompareKeys is not a function #1639

locnguyen opened this issue Sep 29, 2017 · 8 comments

Comments

@locnguyen
Copy link

I'm unclear about what could be wrong here. I copied this out of my app where I'm trying to get the simplest example working with some hardcoded data. Any suggestions?

blueprintjs/core: 1.29.0
blueprintjs/table: 1.26.1

import * as React from 'react';
import { Table, Column, Cell } from '@blueprintjs/table';

class HomePage extends React.Component<{}, {}> {
    render() {
        return (
            <div>
                <h1>Home</h1>

                <Table numRows={10}>
                    <Column name="Foobar" renderCell={idx => <Cell>{idx}</Cell>} />
                </Table>
            </div>
        );
    }
}

export default HomePage;

screen shot 2017-09-29 at 7 49 54 am

@cmslewis
Copy link
Contributor

Hmm, we recently moved that and a few other utility functions from @blueprintjs/table into @blueprintjs/core. Lemme investigate the state of things and get back to you in a bit.

@cmslewis
Copy link
Contributor

cmslewis commented Sep 29, 2017

Okay, I think I found the problem. I think it's a botched 1.26.1 patch release on our end (oh the irony) and will be fixed in our next release, which I hope to cut today. Thanks for filing, @locnguyen! 👍

@patrickdevivo
Copy link

@cmslewis has this been resolved?

@cmslewis
Copy link
Contributor

cmslewis commented Oct 2, 2017

@patrickdevivo Will be resolved today in 1.30.0 (#1642).

@cmslewis cmslewis added the P1 label Oct 2, 2017
@cmslewis
Copy link
Contributor

cmslewis commented Oct 2, 2017

Just cut the 1.30.0 release. Should be resolved now!

@lukas1994
Copy link

could you push 1.30.0 to npm?

@cmslewis
Copy link
Contributor

cmslewis commented Oct 3, 2017

@lukas1994 the build/publish failed due to a flaky test. Retriggered just now.

@cmslewis
Copy link
Contributor

cmslewis commented Oct 3, 2017

@lukas1994 @patrickdevivo - should be published on npm now!

alrocar pushed a commit to CartoDB/franchise that referenced this issue Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants