fix(install): fix resolving duplicate dependencies #21059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 10:51 PM PT - Jul 15th, 2025
@dylan-conway, your commit 2d7fb48 is building: |
| }, | ||
| }; | ||
|
|
||
| try lockfile.buffers.dependencies.append(allocator, dep); |
There was a problem hiding this comment.
Suggested change
| try lockfile.buffers.dependencies.append(allocator, dep); | |
| // We don't need to worry about the resolutions list having a different length than the dependencies list because .... | |
| try lockfile.buffers.dependencies.append(allocator, dep); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Dependency sort order (and priority) is changed to:
Moves
"nodeLinker"from"workspaces"in package.json to bunfig.toml under"linker"."node-linker"(from yarn or pnpm) and"install-strategy"(from npm) can be read from .npmrcFixes a diff bug causing workspaces to be diffed multiple times.
How did you verify your code works?
Added one claude generated test and one handwritten test for the exact behavior.