Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2][devel/nightly] add some missing pytest dependencies #747

Merged
merged 2 commits into from May 8, 2024

Conversation

mikaelarguedas
Copy link
Contributor

Otherwise some jobs based on ros2:devel fail, e.g. if you try to generate coverage for a python package

I took the set of pytest package from the ROS 2 CI:
https://github.com/ros2/ci/blob/3435d04acf17872b07861e81265bc34d7ef40c72/linux_docker_resources/Dockerfile#L120-L125

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas
Copy link
Contributor Author

mikaelarguedas commented May 8, 2024

@nuclearsandwich @clalancette not sure if this is the set of packages users need to test packages with pytest ? or if some are not useful for end users and that's why they are not mentionned in the installation instructions ?

@clalancette
Copy link

@nuclearsandwich @clalancette not sure if this is the set of packages users need to test packages with pytest ? or if some are not useful for end users and that's why they are not mentionned in the installation instructions ?

That seems like a reasonable set.

They aren't mentioned in the installation instructions because they are only useful if you are running tests, i.e. a "debug"-style installation. So to try to keep dependencies smaller, we don't have them.

But you can definitely argue that they should be there for a complete set. If you'd like to open a PR to the documentation to add them, I'd be OK with that.

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas mikaelarguedas merged commit 0cbd0ef into master May 8, 2024
6 checks passed
@mikaelarguedas mikaelarguedas deleted the some-missing-pytest-dependencies branch May 8, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants