Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form: render signatures in children were incompatible with parent(Form) #3349

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kurtbr
Copy link

@kurtbr kurtbr commented Sep 7, 2016

No description provided.

@martin-rueegg
Copy link

Hat the same issue after switching from PHP 5.6 to PHP 7.0.

Thanks for the fix.

@ArthurBorsboom
Copy link

Hi,

Since there has been no commits or responses since July 2016 on the original osTicket project, I have decided to create a fork.

https://github.com/ArthurBorsboom/osTicket

There are many developers who have created awesome improvements by pull requests, which are eagerly waiting for merging.

This is an attempt to incorporate most pull requests to get create an improved version of osTicket. Hopefully this can later be reintegrated in the original project, or if the original project is dead as a rebranded project.

Would you mind to offer your pull request again to this fork?

Best regards,
Arthur Borsboom.

@ntozier
Copy link
Contributor

ntozier commented Oct 16, 2016

How many times did you cross post this message into pull requests? UGH.

@howdu
Copy link

howdu commented Jan 3, 2017

No wonder if it takes this long for something this simple to get fixed. It was reported over 6 months ago and on php7 the cron job doesn't work without these changes.
#3033

@simonnzg
Copy link

simonnzg commented Feb 6, 2017

Still not working on latest Develop. I get an e-mail telling me all about it every time the cron job runs.

@t-oster
Copy link
Contributor

t-oster commented Apr 17, 2017

I can confirm this patch is necessary for PHP 7

Copy link
Contributor

@PeopleInside PeopleInside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be necessary to stop email errors on php 7.1. Thanks for this commit help!
Seems work!

@TechCare-Aus
Copy link
Contributor

I had a discussion going on at the forum - http://osticket.com/forum/discussion/comment/115599#Comment_115599

I can confirm as of 4 hours of testing the mentioned fixes have remedied the issue on my installation and that seems to be the same as what is mentioned here.

VelkyVenik added a commit to VelkyVenik/osTicket that referenced this pull request Nov 20, 2017
@greenlanegreb
Copy link

Yeah I have no idea why, after all this time, your code has not been incorporated into the download. Thanks for the fix :-)

@joeldeteves
Copy link

Can we please include this in the next version (1.10.2)?

Thank you!

tweibert pushed a commit to mairlist/osTicket that referenced this pull request Sep 18, 2018
@thctlo
Copy link

thctlo commented Feb 12, 2019

ping anyone, this is still a warning in Debian stretch osticket 1.10.5 php 7.0

And this patch is not working againts 1.10.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet