Modified to meet PHP 7.2 changes #4133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified code to meet PHP 7.2 changes
Modified code to meet PHP 7.2 changes
Modified code to meet PHP 7.2 changes
Modified code to meet PHP 7.2 changes
Modified code to meet PHP 7.2 changes
Additional !is_null added to line 228 and cleaned up unnecessary count on line 131.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified code in multiple files to meet PHP 7.2 changes. This is not meant to be a complete "fix" but seems to work for common functions.
Includes fix to Forms listed in this pull request #3349 as that is also needed to make it work.
I have not tested this on PHP versions prior to 7.2.1 but I believe it backwards compatible to 7.1 at the very least.
Known bug in claiming a ticket if anyone wants to help with that.