Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add container image for the spa build #334

Merged
merged 1 commit into from May 10, 2024
Merged

add container image for the spa build #334

merged 1 commit into from May 10, 2024

Conversation

qrkourier
Copy link
Member

This container image is in a transitional state now that the node integration is deprecated in favor of the SPA deployment model.

This does not change how the node integration behaves in Docker or Kubernetes. Only the SPA build's base URL is updated with this change. This allows the existing SPA build to be used wherever this image is deployed, most notably by the ziti-controller image, e.g. https://github.com/openziti/ziti/blob/605fe4e5c36c7c898894a4a524603897b81e04e8/dist/docker-images/ziti-controller/Dockerfile#L5.

This image will be refactored once more when the node integration is decommissioned to remove the node integration, preserving only the SPA build.

@qrkourier qrkourier requested review from a team as code owners May 7, 2024 13:53
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ziti-console ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 6:53pm

@qrkourier
Copy link
Member Author

This adjustment fixes a problem when the SPA deployment from this image is used.

The symptom is that the SPA rewrites the URL in the browser's address bar from /zac/login to /login, but /login is not a valid URL because prefix /zac is required to reach the SPA assets served by the controller's web binding.

@dovholuknf
Copy link
Member

@rgallettonf -- please drop a comment here if you are ok with the version changing

@qrkourier
Copy link
Member Author

qrkourier commented May 9, 2024

@rgallettonf -- please drop a comment here if you are ok with the version changing

This doesn't create the release. If we adopt a changelog, then the releaser must ensure the changelog is accurate when they release.

link to the discussion thread about adding a changelog: #334 (comment)

@qrkourier qrkourier requested a review from dovholuknf May 9, 2024 20:30
@rgallettonf
Copy link
Contributor

@rgallettonf -- please drop a comment here if you are ok with the version changing

This doesn't create the release. If we adopt a changelog, then the releaser must ensure the changelog is accurate when they release.

link to the discussion thread about adding a changelog: #334 (comment)
Looks good to me

@qrkourier qrkourier merged commit 89fc0a4 into main May 10, 2024
4 checks passed
@qrkourier qrkourier deleted the set-spa-base-url branch May 10, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants