-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add container image for the spa build #334
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This adjustment fixes a problem when the SPA deployment from this image is used. The symptom is that the SPA rewrites the URL in the browser's address bar from |
0ef64e0
to
b66fe5e
Compare
fb9cc22
to
4c7e6f2
Compare
@rgallettonf -- please drop a comment here if you are ok with the version changing |
link to the discussion thread about adding a changelog: #334 (comment) |
|
b64477e
to
eeae52e
Compare
This container image is in a transitional state now that the node integration is deprecated in favor of the SPA deployment model.
This does not change how the node integration behaves in Docker or Kubernetes. Only the SPA build's base URL is updated with this change. This allows the existing SPA build to be used wherever this image is deployed, most notably by the ziti-controller image, e.g. https://github.com/openziti/ziti/blob/605fe4e5c36c7c898894a4a524603897b81e04e8/dist/docker-images/ziti-controller/Dockerfile#L5.
This image will be refactored once more when the node integration is decommissioned to remove the node integration, preserving only the SPA build.