configure cert trust #284
Closed
configure cert trust #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qrkourier
force-pushed
the
settings-cert-trust
branch
from
1521ad8
to
1789a62
Compare
qrkourier
commented
Mar 28, 2024
| @@ -45,9 +45,9 @@ const __html = '/dist/ziti-console-lib/assets/html'; | |||
|
|
|||
| const loadModule = async (modulePath) => { | |||
| try { | |||
| return await import(modulePath) | |||
| @@ -181,7 +181,8 @@ var bindIP = initial.bindIP; | |||
| var portTLS = initial.portTLS; | |||
| var updateSettings = initial.update; | |||
| var settingsPath = initial.location; | |||
| var rejectUnauthorized = false; | |||
| var rejectUnauthorized = initial.rejectUnauthorized; | |||
There was a problem hiding this comment.
finish implementing rejectUnauthorized (require verifiable TLS server cert from Ziti API)
| @@ -410,23 +419,30 @@ function Authenticate(request) { | |||
| }; | |||
| log("Connecting to: "+serviceUrl+"/authenticate?method=password"); | |||
| //if (request.session.creds != null) { | |||
| external.post(serviceUrl+"/authenticate?method=password", {json: params , rejectUnauthorized: rejectUnauthorized }, function(err, res, body) { | |||
| @@ -438,7 +454,7 @@ function Authenticate(request) { | |||
| */ | |||
| function GetPath() { | |||
| return new Promise(function(resolve, reject) { | |||
| external.get(baseUrl+"/edge/management/v1/version", {rejectUnauthorized: rejectUnauthorized}, function(err, res, body) { | |||
| external.get(baseUrl+"/edge/management/v1/version", tlsOpts, function(err, res, body) { | |||
There was a problem hiding this comment.
always include tlsOpts when calling the Ziti AP
| if (err) { | ||
| log("Add Controller Error"); | ||
| log(err); | ||
| response.json( {error: "Edge Controller not Online", errorObj: err} ); | ||
| response.json( {error: "error adding edge controller", errorObj: err} ); |
There was a problem hiding this comment.
same error if online and GET fails for any other reason, e.g., TLS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@dovholuknf This branch completes the broken implementation of cert verification in the console server app and is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #283