Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude metal-ipi upgrade jobs from using ESI #51504

Merged
merged 1 commit into from
May 1, 2024
Merged

Exclude metal-ipi upgrade jobs from using ESI #51504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions ci-operator/step-registry/ofcir/acquire/ofcir-acquire-commands.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,12 @@ function getCIR(){
fi
}

#CLUSTERTYPE can be one of "virt", "virt-arm64" or "baremetal"
CIRTYPE=host
# Most virt based jobs run on all of the CI hosts, but the diask space available
# in ESI isn't enough for upgrade jobs
CIRTYPE=host,host_esi
[[ "$JOB_NAME" =~ -upgrade- ]] && CIRTYPE=host
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CIRTYPE looks like it’s getting set below, does this get overridden?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if the job is baremetal then it will be overridden, this is expected and also avoids the ESI nodes (they are in our lab)

For "baremetal-moc" CLUSTERTYPE, this only effects one okd job, which we will probably remove soon as its not being maintained.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so it's not set on the job we care about, thanks


#CLUSTERTYPE can be one of "virt", "virt-arm64", "baremetal" or "baremetal-moc"
[ "$CLUSTERTYPE" == "baremetal" ] && CIRTYPE=cluster
[ "$CLUSTERTYPE" == "baremetal-moc" ] && CIRTYPE=cluster_moc
[ "$CLUSTERTYPE" == "virt-arm64" ] && CIRTYPE=host_arm
Expand Down