Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude metal-ipi upgrade jobs from using ESI #51504

Merged
merged 1 commit into from May 1, 2024
Merged

Exclude metal-ipi upgrade jobs from using ESI #51504

merged 1 commit into from May 1, 2024

Conversation

derekhiggins
Copy link
Contributor

They don't have the required diskspace.

@derekhiggins
Exclude metal-ipi upgrade jobs from using ESI
a321c29 
They don't have the required diskspace.
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@derekhiggins: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-machine-api-operator-master-e2e-metal-ipi-sdn openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-master-e2e-metal-ipi-ovn-ipv6 openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-master-e2e-metal-ipi-ovn-dualstack openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.17-e2e-metal-ipi-sdn openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.17-e2e-metal-ipi-ovn-ipv6 openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.17-e2e-metal-ipi-ovn-dualstack openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.16-e2e-metal-ipi-sdn openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.16-e2e-metal-ipi-ovn-ipv6 openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.16-e2e-metal-ipi-ovn-dualstack openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.15-e2e-metal-ipi-sdn openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.15-e2e-metal-ipi-ovn-ipv6 openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.15-e2e-metal-ipi-ovn-dualstack openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.14-e2e-metal-ipi-sdn openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.14-e2e-metal-ipi-ovn-ipv6 openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.14-e2e-metal-ipi-ovn-dualstack openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.13-e2e-metal-ipi-sdn openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.13-e2e-metal-ipi-ovn-ipv6 openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.13-e2e-metal-ipi-ovn-dualstack openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.12-e2e-metal-ipi-sdn openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.12-e2e-metal-ipi-ovn-ipv6 openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.12-e2e-metal-ipi-ovn-dualstack openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.11-e2e-metal-ipi openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.11-e2e-metal-ipi-ovn-ipv6 openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.11-e2e-metal-ipi-ovn-dualstack openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.10-e2e-metal-ipi openshift/machine-api-operator presubmit Registry content changed

A total of 1475 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2024
stbenjam
stbenjam reviewed Apr 30, 2024
View reviewed changes
ci-operator/step-registry/ofcir/acquire/ofcir-acquire-commands.sh
# Most virt based jobs run on all of the CI hosts, but the diask space available
# in ESI isn't enough for upgrade jobs
CIRTYPE=host,host_esi
[[ "$JOB_NAME" =~ -upgrade- ]] && CIRTYPE=host
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CIRTYPE looks like it’s getting set below, does this get overridden?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if the job is baremetal then it will be overridden, this is expected and also avoids the ESI nodes (they are in our lab)

For "baremetal-moc" CLUSTERTYPE, this only effects one okd job, which we will probably remove soon as its not being maintained.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so it's not set on the job we care about, thanks

@derekhiggins
Copy link
Contributor Author

/test ci-operator-registry

@stbenjam
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@derekhiggins
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.15-upgrade-from-stable-4.14-e2e-metal-ipi-upgrade-ovn-ipv6 periodic-ci-openshift-release-master-nightly-4.16-upgrade-from-stable-4.15-e2e-metal-ipi-upgrade-ovn-ipv6 periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6 periodic-ci-openshift-release-master-nightly-4.12-e2e-metal-ipi-sdn-bm periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-ovn-ipv6

@openshift-ci-robot
Copy link
Contributor

@derekhiggins: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@derekhiggins
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.15-upgrade-from-stable-4.14-e2e-metal-ipi-upgrade-ovn-ipv6 periodic-ci-openshift-release-master-nightly-4.16-upgrade-from-stable-4.15-e2e-metal-ipi-upgrade-ovn-ipv6 periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6 periodic-ci-openshift-release-master-nightly-4.12-e2e-metal-ipi-sdn-bm periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-ovn-ipv6

@openshift-ci-robot
Copy link
Contributor

@derekhiggins: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@derekhiggins
Copy link
Contributor Author

/pj-rehearse ack
All 10 rehearse jobs requested (and got) the env type expected

[GIN] 2024/04/30 - 23:07:00 | 200 |   82.177156ms |   10.128.244.34 | POST     "/v1/ofcir?name=rehearse-51504-periodic-ci-openshift-release-master-nightly-4.12-e2e-metal-ipi-sdn-bm/1785445181500166144&type=cluster"
[GIN] 2024/04/30 - 23:07:03 | 200 |   51.250497ms |  10.129.228.105 | POST     "/v1/ofcir?name=rehearse-51504-periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-ovn-ipv6/1785445181571469312&type=host,host_esi"
[GIN] 2024/04/30 - 23:07:03 | 200 |   56.441921ms |   10.128.254.82 | POST     "/v1/ofcir?name=rehearse-51504-periodic-ci-openshift-release-master-nightly-4.15-upgrade-from-stable-4.14-e2e-metal-ipi-upgrade-ovn-ipv6/1785445181240119296&type=host"
[GIN] 2024/04/30 - 23:07:04 | 200 |    52.59861ms |   10.128.223.77 | POST     "/v1/ofcir?name=rehearse-51504-periodic-ci-openshift-release-master-nightly-4.16-upgrade-from-stable-4.15-e2e-metal-ipi-upgrade-ovn-ipv6/1785445181382725632&type=host"
[GIN] 2024/04/30 - 23:07:04 | 200 |   238.28208ms |  10.130.247.165 | POST     "/v1/ofcir?name=rehearse-51504-periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6/1785445181420474368&type=host,host_esi"
[GIN] 2024/05/01 - 07:41:40 | 200 |   66.811037ms |    10.131.57.80 | POST     "/v1/ofcir?name=rehearse-51504-periodic-ci-openshift-release-master-nightly-4.12-e2e-metal-ipi-sdn-bm/1785574754053263360&type=cluster"
[GIN] 2024/05/01 - 07:41:40 | 200 |   57.085163ms |    10.131.77.44 | POST     "/v1/ofcir?name=rehearse-51504-periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-ovn-ipv6/1785574754179092480&type=host,host_esi"
[GIN] 2024/05/01 - 07:41:42 | 200 |   55.976773ms |    10.129.44.53 | POST     "/v1/ofcir?name=rehearse-51504-periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6/1785574754476888064&type=host,host_esi"
[GIN] 2024/05/01 - 07:42:19 | 200 |   60.683472ms |    10.131.57.82 | POST     "/v1/ofcir?name=rehearse-51504-periodic-ci-openshift-release-master-nightly-4.15-upgrade-from-stable-4.14-e2e-metal-ipi-upgrade-ovn-ipv6/1785574754233618432&type=host"
[GIN] 2024/05/01 - 07:42:35 | 200 |   54.888214ms |    10.129.23.67 | POST     "/v1/ofcir?name=rehearse-51504-periodic-ci-openshift-release-master-nightly-4.16-upgrade-from-stable-4.15-e2e-metal-ipi-upgrade-ovn-ipv6/1785574754334281728&type=host"

@openshift-ci-robot
Copy link
Contributor

@derekhiggins: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 1, 2024

@derekhiggins: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.15-upgrade-from-stable-4.14-e2e-metal-ipi-upgrade-ovn-ipv6 a321c29 link unknown /pj-rehearse periodic-ci-openshift-release-master-nightly-4.15-upgrade-from-stable-4.14-e2e-metal-ipi-upgrade-ovn-ipv6
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-ovn-ipv6 a321c29 link unknown /pj-rehearse periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-ovn-ipv6
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.16-upgrade-from-stable-4.15-e2e-metal-ipi-upgrade-ovn-ipv6 a321c29 link unknown /pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-upgrade-from-stable-4.15-e2e-metal-ipi-upgrade-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 56d4f22 into openshift:master May 1, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stbenjam stbenjam stbenjam left review comments

@DennisPeriquet DennisPeriquet Awaiting requested review from DennisPeriquet

@xueqzhan xueqzhan Awaiting requested review from xueqzhan

Assignees

@stbenjam stbenjam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
3 participants
@derekhiggins @openshift-ci-robot @stbenjam