Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-jira: CAPI-Install Feature Gates per Platform #8311

Merged
merged 4 commits into from May 1, 2024
Merged

no-jira: CAPI-Install Feature Gates per Platform #8311

merged 4 commits into from May 1, 2024

Conversation

patrickdillon
Copy link
Contributor

Adds the ability to check for a CAPI install feature gate per platform, rather than only checking whether CAPI is enabled for
every platform. This will allow graduation of capi install feature gates per platform.

@patrickdillon patrickdillon changed the title Capi provider fgs no-jira: CAPI-Install Feature Gates per Platform Apr 24, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 24, 2024
@openshift-ci-robot
Copy link
Contributor

@patrickdillon: This pull request explicitly references no jira issue.

In response to this:

Adds the ability to check for a CAPI install feature gate per platform, rather than only checking whether CAPI is enabled for
every platform. This will allow graduation of capi install feature gates per platform.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@patrickdillon patrickdillon mentioned this pull request Apr 24, 2024
Merged
@r4f4
Copy link
Contributor

r4f4 commented Apr 24, 2024

/hold
For openshift/api#1868 to merge first.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2024
@patrickdillon
features: adapt to new o/api features package
b0b170d 
Features moved to a new package in openshift/api in:
openshift/api@e00b981

This commit just adapts the installer to use the new packages.
@patrickdillon
go.mod: vendor individual capi feature gates
13f69f0 
go get github.com/openshift/api@master
go mod tidy
@patrickdillon
vendor: o/api capi provider feature gates
b1b7bb4 
go mod vendor
@patrickdillon
Check CAPI-Install feature gate per platform
cc6a078 
Adds the ability to check for a CAPI install feature gate per
platform, rather than only checking whether CAPI is enabled for
every platform. This will allow graduation of capi install
feature gates per platform.
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2024
@patrickdillon
Copy link
Contributor Author

/hold cancel
openshift/api#1868 is now vendored

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2024
@patrickdillon patrickdillon mentioned this pull request Apr 29, 2024
Open
r4f4
r4f4 reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Nice breakdown per commit, easy to review 👍

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@patrickdillon
Copy link
Contributor Author

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@r4f4
Copy link
Contributor

r4f4 commented Apr 29, 2024

The openstack-capi-manifests error might be relevant:

level=error msg=failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: failed to unmarshal install-config.yaml: error converting YAML to JSON: yaml: unmarshal errors:
level=error msg=  line 6: key "featureSet" already set in map

@pierreprinetti can you double check?

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c2fa2bf and 2 for PR HEAD cc6a078 in total

@r4f4
Copy link
Contributor

r4f4 commented Apr 29, 2024

I see the openstack-manifests failure in another PR, so probably not related to the changes in this PR: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_installer/8196/pull-ci-openshift-installer-master-altinfra-openstack-capi-manifests/1784989962907684864

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1a3d6c2 and 1 for PR HEAD cc6a078 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 55f8072 and 0 for PR HEAD cc6a078 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision cc6a078 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2024
@pierreprinetti
Copy link
Member

/skip altinfra-openstack-capi-manifests

@pierreprinetti
Copy link
Member

/hold cancel
openstack-capi-manifests is no longer blocking; we will fix it when we add actual CAPI tests.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2024
@pierreprinetti
Copy link
Member

/test altinfra-openstack-capi-manifests

@r4f4
Copy link
Contributor

r4f4 commented Apr 30, 2024

/hold
We'll merge this as soon as #8196 merges.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2024
@r4f4
Copy link
Contributor

r4f4 commented Apr 30, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e6b59d5 and 2 for PR HEAD cc6a078 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f3d9c1f and 1 for PR HEAD cc6a078 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 1, 2024

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-proxy cc6a078 link false /test e2e-openstack-proxy
ci/prow/e2e-gcp-secureboot cc6a078 link false /test e2e-gcp-secureboot
ci/prow/okd-e2e-aws-ovn-upgrade cc6a078 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node cc6a078 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-vsphere-zones cc6a078 link false /test e2e-vsphere-zones
ci/prow/e2e-gcp-ovn-shared-vpc cc6a078 link false /test e2e-gcp-ovn-shared-vpc
ci/prow/e2e-azurestack cc6a078 link false /test e2e-azurestack
ci/prow/altinfra-openstack-capi-manifests cc6a078 link false /test altinfra-openstack-capi-manifests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f668504 into openshift:master May 1, 2024
37 of 45 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.17.0-202405010518.p0.gf668504.assembly.stream.el9 for distgit ose-installer-altinfra.
All builds following this will include this PR.

@deads2k deads2k mentioned this pull request May 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4f4 r4f4 r4f4 left review comments

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

Assignees

@r4f4 r4f4

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@patrickdillon @openshift-ci-robot @r4f4 @pierreprinetti @openshift-bot @openshift-merge-robot