Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: Allow DevPreviewNoUpgrade #8327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NO-JIRA: Allow DevPreviewNoUpgrade #8327

wants to merge 1 commit into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 29, 2024

Allow installing of openshift/api#1825

@patrickdillon
Copy link
Contributor

There's some overlap here with what I was doing in 62e2d44 to adapt to the api changes that moved features to their own package.

Let me bump 8311 now that the dependent api pr has merged.

@patrickdillon
Copy link
Contributor

patrickdillon commented Apr 29, 2024 •
edited

i have now bumped #8311
if we can merge that, you might be able to drop everything except your last commit, 8d925cb

@deads2k
Copy link
Contributor Author

deads2k commented Apr 29, 2024

i have now bumped #8311
if we can merge that, you might be able to drop everything except your last commit, 8d925cb

Great! Will rebase after that merges.

@patrickdillon
Copy link
Contributor

i have now bumped #8311
if we can merge that, you might be able to drop everything except your last commit, 8d925cb

Great! Will rebase after that merges.

merged

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2024
@patrickdillon
Copy link
Contributor

you need to run go generate ./pkg/types/installconfig.go for the failing verify-vendor test

@patrickdillon
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@deads2k
Copy link
Contributor Author

deads2k commented May 8, 2024

/retest

patrickdillon
patrickdillon reviewed May 8, 2024
View reviewed changes
pkg/explain/printer_test.go
@@ -61,7 +61,7 @@ func Test_PrintFields(t *testing.T) {
FeatureGates enables a set of custom feature gates. May only be used in conjunction with FeatureSet "CustomNoUpgrade". Features may be enabled or disabled by providing a true or false value for the feature gate. E.g. "featureGates": ["FeatureGate1=true", "FeatureGate2=false"].

featureSet <string>
FeatureSet enables features that are not part of the default feature set. Valid values are "Default", "TechPreviewNoUpgrade" and "CustomNoUpgrade". When omitted, the "Default" feature set is used.
FeatureSet enables features that are not part of the default feature set. Valid values are "Default", "TechPreviewNoUpgrade", "DevPreviewNoUpgrade", and "CustomNoUpgrade". When omitted, the "Default" feature set is used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FeatureSet enables features that are not part of the default feature set. Valid values are "Default", "TechPreviewNoUpgrade", "DevPreviewNoUpgrade", and "CustomNoUpgrade". When omitted, the "Default" feature set is used.
FeatureSet enables features that are not part of the default feature set. Valid values are "Default", "TechPreviewNoUpgrade", "DevPreviewNoUpgrade", and "CustomNoUpgrade". When omitted, the "Default" feature set is used.

@deads2k there's an extra space here, causing the unit tests to fail. This test is the worst. We need to rework it.

@deads2k deads2k changed the title Allow DevPreviewNoUpgrade NO-JIRA: Allow DevPreviewNoUpgrade May 9, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2024
@openshift-ci-robot
Copy link
Contributor

@deads2k: This pull request explicitly references no jira issue.

In response to this:

Allow installing of openshift/api#1825

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD bbca50f and 2 for PR HEAD 86ff5da in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d08c982 and 1 for PR HEAD 86ff5da in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3420c22 and 0 for PR HEAD 86ff5da in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 10, 2024

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-fips 8d925cb link false /test e2e-aws-ovn-fips
ci/prow/e2e-aws-custom-security-groups 8d925cb link false /test e2e-aws-custom-security-groups
ci/prow/openstack-manifests 8d925cb link true /test openstack-manifests
ci/prow/altinfra-e2e-aws-ovn 8d925cb link false /test altinfra-e2e-aws-ovn
ci/prow/e2e-aws-ovn-edge-zones 8d925cb link false /test e2e-aws-ovn-edge-zones
ci/prow/e2e-aws-ovn-single-node 8d925cb link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-edge-zones-manifest-validation 8d925cb link true /test e2e-aws-ovn-edge-zones-manifest-validation
ci/prow/e2e-openstack-proxy 8d925cb link false /test e2e-openstack-proxy
ci/prow/altinfra-openstack-capi-manifests 8d925cb link true /test altinfra-openstack-capi-manifests
ci/prow/e2e-gcp-ovn-shared-vpc 8d925cb link false /test e2e-gcp-ovn-shared-vpc
ci/prow/e2e-openstack-ovn 8d925cb link true /test e2e-openstack-ovn
ci/prow/e2e-gcp-ovn 8d925cb link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones 8d925cb link false /test e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/e2e-aws-ovn-shared-vpc 8d925cb link false /test e2e-aws-ovn-shared-vpc
ci/prow/e2e-openstack-nfv-intel 8d925cb link false /test e2e-openstack-nfv-intel
ci/prow/e2e-gcp-ovn-xpn 8d925cb link false /test e2e-gcp-ovn-xpn
ci/prow/e2e-gcp-secureboot 8d925cb link false /test e2e-gcp-secureboot
ci/prow/e2e-aws-ovn-imdsv2 8d925cb link false /test e2e-aws-ovn-imdsv2
ci/prow/e2e-azurestack 86ff5da link false /test e2e-azurestack
ci/prow/e2e-metal-assisted 86ff5da link false /test e2e-metal-assisted
ci/prow/e2e-metal-single-node-live-iso 86ff5da link false /test e2e-metal-single-node-live-iso
ci/prow/okd-e2e-aws-ovn-upgrade 86ff5da link false /test okd-e2e-aws-ovn-upgrade
ci/prow/unit 86ff5da link true /test unit
ci/prow/aro-unit 86ff5da link true /test aro-unit
ci/prow/okd-unit 86ff5da link true /test okd-unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 86ff5da was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@iurygregory iurygregory Awaiting requested review from iurygregory

@mtulio mtulio Awaiting requested review from mtulio

Assignees

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deads2k @patrickdillon @openshift-ci-robot @openshift-merge-robot