Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip running gradle checks on release notes #13477

Merged
merged 2 commits into from
May 1, 2024

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Apr 30, 2024

Description

Running gradle check on release notes does not provide any value but instead adds a huge overhead while merging PRs during release cycle. Had to wait for 2+ hours during 2.13.0 while creating RC as release notes if one of the entrance criteria to start the release window.
Please let me know if we should include all .mdfiles as well .github directory to this list as well.

Related Issues

opensearch-project/opensearch-build#4562

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@reta
Copy link
Collaborator

reta commented Apr 30, 2024

@gaiksaya see please #13085

Copy link
Contributor

✅ Gradle check result for 35f2eee: SUCCESS

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.47%. Comparing base (b15cb0c) to head (8e0d3ff).
Report is 246 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13477      +/-   ##
============================================
+ Coverage     71.42%   71.47%   +0.04%     
- Complexity    59978    60975     +997     
============================================
  Files          4985     5050      +65     
  Lines        282275   286804    +4529     
  Branches      40946    41550     +604     
============================================
+ Hits         201603   204979    +3376     
- Misses        63999    64847     +848     
- Partials      16673    16978     +305     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kotwanikunal
Copy link
Member

@reta I think this makes it easier coming in from a strictly onlyContains(*) POV.
We can keep adding path/files to this as we find fit.
Thanks @gaiksaya for moving this along :)

@gaiksaya
Copy link
Member Author

@kotwanikunal @reta Can I merge this as is or do you have recommendations on more things to add under paths-ignore?

@kotwanikunal
Copy link
Member

.github, *.md would be straightaway useful as well.

@reta
Copy link
Collaborator

reta commented Apr 30, 2024

@kotwanikunal @reta Can I merge this as is or do you have recommendations on more things to add under paths-ignore?

I think the intention was to cover larger scope of changes that do not require check runs, leaving it up to @kotwanikunal since he was working on it.

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya
Copy link
Member Author

.github, *.md would be straightaway useful as well.

Done!

Copy link
Contributor

github-actions bot commented May 1, 2024

❌ Gradle check result for 8e0d3ff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 1, 2024

✅ Gradle check result for 8e0d3ff: SUCCESS

@gaiksaya gaiksaya merged commit 1765e20 into opensearch-project:main May 1, 2024
28 checks passed
@gaiksaya gaiksaya deleted the gradle-check branch May 1, 2024 01:28
@gaiksaya gaiksaya added the backport 2.x Backport to 2.x branch label May 1, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 1, 2024
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
(cherry picked from commit 1765e20)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@gaiksaya
Copy link
Member Author

gaiksaya commented May 1, 2024

Added backport 2x label. @rishabh6788 @bbarani leaving upto you if you want this in 2.14 branch. Might help save sometime (actually hours) for things like release notes and .md changes.

@bbarani
Copy link
Member

bbarani commented May 1, 2024

@rishabh6788 Lets backport this to 2.14 branch.

@gaiksaya gaiksaya added the backport 2.14 Backport to 2.14 branch label May 1, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 1, 2024
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
(cherry picked from commit 1765e20)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request May 1, 2024
(cherry picked from commit 1765e20)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peternied pushed a commit that referenced this pull request May 1, 2024
(cherry picked from commit 1765e20)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peternied added a commit that referenced this pull request May 2, 2024
peternied added a commit that referenced this pull request May 2, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 7, 2024
This reverts commit 1765e20.

(cherry picked from commit 00947fc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 7, 2024
This reverts commit 1765e20.

(cherry picked from commit 00947fc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gaiksaya pushed a commit that referenced this pull request May 7, 2024
#13585)

This reverts commit 1765e20.

(cherry picked from commit 00947fc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gaiksaya pushed a commit that referenced this pull request May 7, 2024
#13586)

This reverts commit 1765e20.

(cherry picked from commit 00947fc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
finnegancarroll pushed a commit to finnegancarroll/OpenSearch that referenced this pull request May 10, 2024
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
finnegancarroll pushed a commit to finnegancarroll/OpenSearch that referenced this pull request May 10, 2024
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request May 17, 2024
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request May 17, 2024
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.14 Backport to 2.14 branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants