Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Skip running gradle checks on release notes" #13499

Merged
merged 1 commit into from
May 2, 2024

Conversation

peternied
Copy link
Member

@peternied peternied commented May 2, 2024

Description

Reverts #13477

We are seeing changes that are stalled because gradle check which is required by branch protections isn't being triggered, see stuck PR [1]. While we get an updated solution [2] in place, reverting this change.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

@peternied peternied added Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. Other labels May 2, 2024
@peternied peternied merged commit 00947fc into main May 2, 2024
36 of 43 checks passed
@andrross andrross added backport 2.x Backport to 2.x branch backport 2.14 Backport to 2.14 branch labels May 7, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 7, 2024
This reverts commit 1765e20.

(cherry picked from commit 00947fc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 7, 2024
This reverts commit 1765e20.

(cherry picked from commit 00947fc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gaiksaya pushed a commit that referenced this pull request May 7, 2024
#13585)

This reverts commit 1765e20.

(cherry picked from commit 00947fc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gaiksaya pushed a commit that referenced this pull request May 7, 2024
#13586)

This reverts commit 1765e20.

(cherry picked from commit 00947fc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
finnegancarroll pushed a commit to finnegancarroll/OpenSearch that referenced this pull request May 10, 2024
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request May 17, 2024
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.14 Backport to 2.14 branch Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. Other skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants