fix: use rawUrl for path
#954
Conversation
|
✔️ Deploy Preview for netlify-plugin-nextjs-demo ready! 🔨 Explore the source changes: 9883791 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/61b32d88b5b77300074075ba 😎 Browse the preview: https://deploy-preview-954--netlify-plugin-nextjs-demo.netlify.app |
|
✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready! 🔨 Explore the source changes: 9883791 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61b32d880b01d7000952d244 😎 Browse the preview: https://deploy-preview-954--netlify-plugin-nextjs-static-root-demo.netlify.app |
|
✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready! 🔨 Explore the source changes: 9883791 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61b32d8889d0a00008c6f74d 😎 Browse the preview: https://deploy-preview-954--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app/ |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
fix: wip path encoding chore: log event chore: use rawurl chore: use rawurl
ascorbic
force-pushed
the
mk/encoding-path
branch
from
cc33c50 to
ed197d4
Compare
Summary
Netlify Functions events have a bug where the
event.pathis decoded, so can end up with illegal characters. To work around this, this PR switches to usingrawUrldirectly, which is still encoded. This bug was manifesting when a URL contained an encoded#character, which if decoded would cause the rest of the URL to be treated as a fragment rather than part of the path.Test plan
#character (%23)Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #952
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.