Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨(frontend) conditionaly show attestation tab #2387

Merged
merged 1 commit into from May 17, 2024

Conversation

rlecellier
Copy link
Collaborator

@rlecellier rlecellier commented Apr 26, 2024

note: rebased on #2370

Purpose

On certificate page, we don't want user that only have regular
certificate to see an empty "attestation certificate" tab.

@rlecellier rlecellier force-pushed the rlecellier/do_not_display_attestation_tab branch from 18dc92d to db66396 Compare May 13, 2024 08:55
@rlecellier rlecellier force-pushed the rlecellier/do_not_display_attestation_tab branch from db66396 to 98ca61c Compare May 13, 2024 12:28
@rlecellier rlecellier force-pushed the rlecellier/do_not_display_attestation_tab branch 5 times, most recently from 28681da to e134a92 Compare May 16, 2024 15:33
Copy link
Member

@jbpenrath jbpenrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick, otherwise it looks good to me ✅

src/frontend/js/pages/DashboardCertificates/index.tsx Outdated Show resolved Hide resolved
src/frontend/js/pages/DashboardCertificates/index.tsx Outdated Show resolved Hide resolved
@rlecellier rlecellier force-pushed the rlecellier/do_not_display_attestation_tab branch 2 times, most recently from 0dfb0fb to fea556e Compare May 17, 2024 12:32
On certificate page, we don't want user that only have regular
certificate to see an empty "attestation certificate" tab.
@rlecellier rlecellier force-pushed the rlecellier/do_not_display_attestation_tab branch from fea556e to 13b4bfd Compare May 17, 2024 14:10
@rlecellier rlecellier merged commit c84334e into master May 17, 2024
20 checks passed
@rlecellier rlecellier deleted the rlecellier/do_not_display_attestation_tab branch May 17, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants