✨(frontend) split dashboard certifiate page #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlecellier
force-pushed
the
rlecellier/learner_dashboard_split_certificate_page
branch
5 times, most recently
from
25ddcbe
to
cd8ce34
Compare
rlecellier
force-pushed
the
rlecellier/learner_dashboard_split_certificate_page
branch
from
cd8ce34
to
95dd442
Compare
jbpenrath
reviewed
Apr 23, 2024
rlecellier
force-pushed
the
rlecellier/learner_dashboard_split_certificate_page
branch
7 times, most recently
from
7e6e527
to
80b434a
Compare
jbpenrath
reviewed
Apr 25, 2024
Comment on lines
36
to
42
| <Tabs.Tab | ||
| name="enrollment-certificate-tab" | ||
| initialIsActive={certificateType === CertificateType.ENROLLMENT} | ||
| href={generatePath(LearnerDashboardPaths.ENROLLMENT_CERTIFICATES)} | ||
| > | ||
| <FormattedMessage {...messages.enrollmentCertificateTabLabel} /> | ||
| </Tabs.Tab> |
There was a problem hiding this comment.
I just remember that we talked to hide this tab if the user has no certificate of this kind. Maybe we could do that in another PR ?
There was a problem hiding this comment.
i would prefere yes, it's a different journey.
edit: PR #2387
rlecellier
force-pushed
the
rlecellier/learner_dashboard_split_certificate_page
branch
from
80b434a
to
034fc91
Compare
rlecellier
force-pushed
the
rlecellier/learner_dashboard_split_certificate_page
branch
4 times, most recently
from
876fce1
to
034a2c3
Compare
jbpenrath
approved these changes
May 15, 2024
| const TabContextProvider = ({ | ||
| initialActiveTabName, | ||
| children, | ||
| }: PropsWithChildren & { initialActiveTabName?: string }) => { |
There was a problem hiding this comment.
Suggested change
| }: PropsWithChildren & { initialActiveTabName?: string }) => { | |
| }: PropsWithChildren<{ initialActiveTabName?: string }>) => { |
| const Tabs = ({ | ||
| initialActiveTabName, | ||
| children, | ||
| }: PropsWithChildren & { initialActiveTabName: string }) => { |
There was a problem hiding this comment.
Suggested change
| }: PropsWithChildren & { initialActiveTabName: string }) => { | |
| }: PropsWithChildren<{ initialActiveTabName: string }>) => { |
| const { activeTabName, setActiveTabName } = useContext(TabsContext); | ||
| const navigate = useNavigate(); | ||
|
|
||
| const isActive = !!activeTabName && activeTabName === name; |
There was a problem hiding this comment.
I think this should work ?
Suggested change
| const isActive = !!activeTabName && activeTabName === name; | |
| const isActive = activeTabName === name; |
Comment on lines
60
to
62
| {certificates.items.length === 0 && ( | ||
| <Banner message={intl.formatMessage(messages.empty)} type={BannerType.INFO} /> | ||
| )} |
There was a problem hiding this comment.
IMO, we should not display this banner until we are fetching data.
Currently, there is flickering effect when switching tab.
CleanShot.2024-05-15.at.19.29.28.mp4
rlecellier
force-pushed
the
rlecellier/learner_dashboard_split_certificate_page
branch
2 times, most recently
from
e40c1ed
to
ba8f711
Compare
jbpenrath
approved these changes
May 16, 2024
rlecellier
force-pushed
the
rlecellier/learner_dashboard_split_certificate_page
branch
4 times, most recently
from
f4c5d06
to
9916c59
Compare
rlecellier
force-pushed
the
rlecellier/learner_dashboard_split_certificate_page
branch
from
9916c59
to
330d141
Compare
We need a basic tab component to render two linked section in the learner dashbaord certificates page.
build cunningham theme with new entries for tabs.
joanie's certificate endpoint now return only order's certificate by default. to retrive enrollments certificate we need a second request with the right filter. Here we add tab in learner dashboard certificate page to render both list: order and enrollments certificates
certificate entry on learner sidebar menu can render multiple routes: * order certificate * enrollment certificate our menu item must be selected when any of theses two route is active.
jbpenrath
force-pushed
the
rlecellier/learner_dashboard_split_certificate_page
branch
from
330d141
to
bb2ec6e
Compare
rlecellier
deleted the
rlecellier/learner_dashboard_split_certificate_page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
joanie's certificate endpoint now return only order's certificate by
default.
to retrive enrollments certificate we need a second request with the
right filter.
Here we add tab in learner dashboard certificate page to render both
list: order and enrollments certificates
Capture vidéo du 25-04-2024 16:39:29.webm