Simplify adding photos by removing 2 of the 4 steps #3332
Comments
|
@stephanegigandet My remarks:
I've just double checked with whatsapp:
|
|
For us it's a bit different: when we add a new product, we want to add 3 or 4 pictures, we don't have filters, stickers etc. We just want to upload pictures as quickly as possible. So I think it makes sense to remove confirmation steps that don't really bring value. I'm guessing that step 2. is somehow added by Samsung, but maybe there's a way to disable it, and ask for the camera to not require a confirmation. For step 3/4, I think we can merge them with clearer buttons. e.g.
|
|
@stephanegigandet So if I compact it my way, could we say:
That said, it won't be exactly the same with an existing picture. In that case you need to be able to take another picture (and also to cancel). That would mean 4 buttons: "change picture", "cancel", "rotate", "send". That's a lot. There's no way you can get rid of "cancel", "rotate", "send". Or, if we rely on the "X" in the title, users may cancel with it. That would mean:
Do we agree on that? |
Sounds good to me. Could we also get rid of the Profile / Search / History button bar on this screen? The user is focused on adding photos, so we should avoid distractions and buttons that can cause misclicks / mistaps.
|
That would seem appropriate, but I'm not sure if this can be done easily. Creating a new issue about it... |
|
Now we're in a sort of collision between expected behaviors. Today, when we click on an image in the product page P ("Product"), we go to page M ("Main") with the main 4 images. The collision is here:
If we do both at the same time, that means that on page C, we can
Looks a bit too much to me, like a Welsh card game. Let alone the fact that some day we'll have to deal with "other" images. I'm afraid we have to get rid of one the suggested behaviors, and I would say the swipe effect should be forgotten. |
Yeah, Right. Instead of simplifying the process, Swiping effects complicates it. |
|
|
Thank you @teolemon for your videos! Now the question is: which actions do we want to facilitate/encourage?
The answer may be: both. That would mean 2 specific image edit modes:
|
|
This is the current behavior if someone wants to change an image...
This is what I suggest:
A bit faster, isn't it? If ever you want to go the other 3 images, we can imagine a navigation from top bar:
|
|
Well we probably should not assume that the intent of people clicking on the top photos is to change them. If I had to guess, I would think the most common intent is going to be to see the picture in full scale (especially since we hide the bottom of the part of the pictures thumbnails with the top of the product card (which I personaly find very annoying but that's another story)). So the current behaviour that lists the 4 pictures and then opens them in full screen is ok I think. Then we could have fewer edit screens indeed. Screen 3 could be : show image + Take another button + Edit button Then next screen is taking the picture (if take another button) or directly the screen with "Take another, crop, send" (edit button, or just after taking a new picture). |
|
What about this?
@stephanegigandet @teolemon @omkarChend1kar Your opinion?
|
@monsieurtanuki Somewhat like this only, I had imagined except skipping gallery view, But was concerned about how we are going to switch between swiping and allowing to edit a current image being shown #3325 (comment) |
@omkarChend1kar My remarks:
|
@monsieurtanuki: I like it a lot, great idea! :) I'm not sure if there's enough room, but it would great in step 3 to very clearly say that we are modifying the photo for the ingredients, or the nutrition facts etc. Maybe "Ingredients photo" instead of "Modifier la photo"? It's clear it's an edit screen anyway. One thing we might do is that if people click on "Confirm" when there are no changes (no new photo, no changed crop / rotation), we just close without changing anything. |
Good point.
The reverse should be true too: changing and going back should trigger a "do you want your changes to be saved?" dialog. |
@monsieurtanuki In that case, I can try getting rid of gallery view, And push the changes so that you can have the access to
Such that you can make changes to skip one screen and go to crop page, That works ? |
|
@omkarChend1kar Please do finish #3325 without any change to the gallery. Let's do it step by step, PR by PR (as a reviewer, I would appreciate that). |
As per intended behavior required by #3129 ,It's already finished as mentioned in #3325 (comment) ,Please review it @monsieurtanuki |
|
@omkarChend1kar Please solve the conflicts. |
…mage view (Conflicts after openfoodfacts#3332)
@monsieurtanuki Yeah right, My bad, Please check now. |
|
Actually it's a bit tricky to do that now because:
The first part of the issue is going to be changing the new crop page:
Once the old crop page is definitely removed, we can go to the second step:
And whenever we want, there's the optional bonus step:
|
|
Problem already suggested by @stephanegigandet: if we put an extra "camera" button, we have a bottom bar of 3 items, which looks a lot similar to the navigation tabs |
|
Current behaviour:
Suggestion:
Merge 2. 3. and 4. into a single Crop interface (same as today's + a Retry button). I don't think we need an extra confirmation step, we can submit the image as soon as the user hits "ok" on the crop screen.
The text was updated successfully, but these errors were encountered: