Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the Bottom Navigation Bar on some pages #3337

Closed
monsieurtanuki opened this issue Nov 21, 2022 · 9 comments
Closed

Get rid of the Bottom Navigation Bar on some pages #3337

monsieurtanuki opened this issue Nov 21, 2022 · 9 comments

Comments

@monsieurtanuki
Copy link
Contributor

monsieurtanuki commented Nov 21, 2022

What

  • Could we also get rid of the Profile / Search / History button bar on this screen? The user is focused on adding photos, so we should avoid distractions and buttons that can cause misclicks / mistaps.

Screenshot

image

Originally posted by @stephanegigandet in #3332 (comment)

@prathamsoni11
Copy link
Contributor

Can I work on this?

@monsieurtanuki
Copy link
Contributor Author

Before any code and any PR, please write here how you plan to do it.
This issue really seems like a pain in the neck :(
Good luck @prathamsoni11!

@prathamsoni11
Copy link
Contributor

Before any code and any PR, please write here how you plan to do it.
This issue seems like a pain in the neck :(
Good luck @prathamsoni11!

Yes, you were right this issue is like a pain in the neck. But I tried this issue and come up that the BottomNavigation is in the root I tried to disable it from the root and it worked but the issue is that the application is throwing a "context" error due to the removal of the root.

@prathamsoni11
Copy link
Contributor

But I will try this issue once more to resolve this issue.

@monsieurtanuki
Copy link
Contributor Author

As you wish. For the record this is not an important issue at all and we have many P0 P1 P2 issues that deserve more attention.

@monsieurtanuki
Copy link
Contributor Author

@prathamsoni11 Still working on it?

@prathamsoni11
Copy link
Contributor

@monsieurtanuki no

@monsieurtanuki
Copy link
Contributor Author

monsieurtanuki commented Mar 15, 2023

@monsieurtanuki
Copy link
Contributor Author

@stephanegigandet I don't know why but from weeks on we now have rarely the bottom navigation bar except in rare "main" pages, which means we may close the current issue.
Feel free to reopen it and/or and details about the problematic pages if relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants