Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Image cropper] Buttons with too small touch areas #3392

Closed
g123k opened this issue Dec 1, 2022 · 6 comments
Closed

[Image cropper] Buttons with too small touch areas #3392

g123k opened this issue Dec 1, 2022 · 6 comments
Assignees
Labels
Milestone

Comments

@g123k
Copy link
Collaborator

g123k commented Dec 1, 2022

On the image cropper, the two bottom buttons have two small touch areas. Each should take 50% of the screen's width.

IMG_1250

@g123k g123k added 🐛 bug Something isn't working 🎨 UI / UX labels Dec 1, 2022
@omkarChend1kar
Copy link
Contributor

I can look into this!!

@g123k
Copy link
Collaborator Author

g123k commented Dec 1, 2022

Ok, I also assign you this issue

@omkarChend1kar
Copy link
Contributor

@g123k Giving each button a 50% of touch area, May result any accidental rotate or Okay button events if wasn't intended in first place, Instead of that I think we can make buttons itself somewhat bigger, What say?

@teolemon teolemon added this to the 4.2 milestone Dec 1, 2022
@g123k
Copy link
Collaborator Author

g123k commented Dec 1, 2022

Yes, they should also be bigger in height

@monsieurtanuki
Copy link
Contributor

@omkarChend1kar Probably in collision with #3332 - as we need to add a button that will visually cause confusion, we need to change the UI altogether.

@monsieurtanuki
Copy link
Contributor

@g123k @omkarChend1kar Closing this issue as we now have a different layout:
Capture d’écran 2022-12-10 à 09 10 13

Feel free to open a new issue about the new layout if relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants